Repository navigation
fix(crons)!: Add before_send_check_in, don't run before_send on check-ins - #8184
Merged
Merged
Conversation
…-ins Check-ins must not go through before_send according to the check-in spec. Add a dedicated before_send_check_in option instead and record check-ins dropped by it under the monitor data category.
sentrivana
changed the title
before_send_check_in, don't run before_send on check-ins
sentrivana
marked this pull request as ready for review
November 4, 2026 15:16
Contributor
Coverage Results 📊✅ 57836 passed | ⏭️ 3008 skipped | Total: 60844 | Pass Rate: 95.06% | Execution Time: 166m 10s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00% (6 of 6 changed executable lines covered; target 80%). Changed files with executable lines (1)
Coverage diff@@ Coverage Diff @@
## master #8184 +/-##
==========================================
+ Coverage 90.32% 90.38% +0.06%
==========================================
Files 203 199 -4
Tracked lines 26905 21303 -5602
Branches 10048 7366 -2682
==========================================
- Hits 24302 19254 -5048
+ Misses 2603 2049 -554
+ Partials 1516 1233 -283Generated by Coverage Action |
alexander-alderman-webb
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the check-in spec, check-ins MUST NOT go through
before_send. SDKs may offer a separatebeforeSendCheckInhook instead.before_send.before_send_check_inoption to modify or drop check-ins.before_send_check_inare recorded under themonitordata category in client reports (previouslyerror).This is technically a bugfix, but the incorrect behavior has been out there for so long that it may now be expected behavior, so considering this breaking.
Issues
Closes #4814
Reminders
uv run ruff.feat:,fix:,ref:,meta:)