Skip to content

ref(sessions): Remove unused TERMINAL_SESSION_STATES constant - #8151

Merged
sentrivana merged 1 commit into
masterfrom
ivana/remove-terminal-session-states
Oct 29, 2026
Merged

sentrivana merged 1 commit into
masterfrom
ivana/remove-terminal-session-states

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the module-level TERMINAL_SESSION_STATES tuple from sentry_sdk/sessions.py. It has never been read anywhere.

#627 (Mar 2020) added it with the original session tracking code, and #985 (Feb 2021) moved it a few lines down. Neither change, nor any other commit, added a use of it. Session status handling (Session.close(), SessionFlusher aggregation) compares against the status literals directly.

Evidence

Why it's safe

  • It's a plain constant in an internal module. It's not re-exported from sentry_sdk and doesn't appear in docs/, CHANGELOG.md or MIGRATION_GUIDE.md.
  • It was never read at runtime, so behavior doesn't change.

Issues

n/a

via Ivana Kellyer.

--

View Junior Session [Sentry]

Co-Authored-By: Ivana Kellyer <ivana.kellyer@sentry.io>
@sentry-junior
sentry-junior Bot requested a review from a team as a code owner October 29, 2026 10:46
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 447m 26s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ Test counts unchanged from base.

All tests are passing successfully.

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.31% (up 0.01 percentage points from base (825ff97) to head (583ac5d)).

Files with missing lines (1)
File Coverage % Lines
sentry_sdk/sessions.py 90.91% ⚠️ 12 Missing and 9 partials
Coverage diff
@@            Coverage Diff             @@
##        master     #8151       +/-##
==========================================
+ Coverage    90.30%    90.31%    +0.01%
==========================================
  Files          203       203         —
  Tracked lines     26873     26872        -1
  Branches     10044     10044         —
==========================================
+ Hits         24266     24267        +1
+ Misses        2607      2605        -2
+ Partials      1520      1518        -2

Generated by Coverage Action

@sentrivana
sentrivana merged commit 7ad4e1a into master Oct 29, 2026
172 checks passed
@sentrivana
sentrivana deleted the ivana/remove-terminal-session-states branch October 29, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant