Repository navigation
feat(boto3): Add SQS/SNS trace propagation - #8145
Open
pabloDeputter wants to merge 4 commits into
Open
pabloDeputter wants to merge 4 commits into
pabloDeputter wants to merge 4 commits into
Conversation
Contributor
Coverage Results 📊✅ 58450 passed | ⏭️ 3018 skipped | Total: 61468 | Pass Rate: 95.09% | Execution Time: 161m 28s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 94.19% (81 of 86 changed executable lines covered; target 80%). Changed files with executable lines (6)
Coverage diff@@ Coverage Diff @@
## master #8145 +/-##
==========================================
+ Coverage 90.35% 90.45% +0.10%
==========================================
Files 203 199 -4
Tracked lines 26931 21498 -5433
Branches 10058 7468 -2590
==========================================
- Hits 24331 19444 -4887
+ Misses 2600 2054 -546
+ Partials 1517 1236 -281Generated by Coverage Action |
Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com> # Conflicts: # sentry_sdk/integrations/boto3/_services/sqs.py
Send a message, receive what was injected, and check that the receive span links to the send span. Covers SQS and an SNS notification delivered to SQS without raw message delivery. Co-Authored-By: johdax <114897+dingsdax@users.noreply.github.com>
…/sns-propagation Co-Authored-By: Johannes Daxböck <114897+dingsdax@users.noreply.github.com> # Conflicts: # sentry_sdk/integrations/boto3/_services/sns.py # sentry_sdk/integrations/boto3/_services/sqs.py # sentry_sdk/integrations/boto3/_utils.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagates the trace through SQS and SNS messages, so the consumer can be linked back to the request that sent the message.
Send side (
SendMessage,SendMessageBatch,Publish,PublishBatch):sentry-traceandbaggageasStringmessage attributes, on the message or on each batch entry.trace_propagation_targetsmatch the endpoint.Receive side (
ReceiveMessage):sentry-traceandbaggagetoMessageAttributeNames, so SQS returns them. Only when the span is recorded, and not when the caller already asks forAllor.*.sentry.link.type: message_origin.Tests: injection and extraction for single and batch calls, the limits above, and a round-trip test: send a message, receive what was injected, and check that the link points at the send span.
Stacked on #8142 (SNS), which is stacked on #8137 (SQS).
Issues
via @dingsdax.
--
View Session [Sentry]