Skip to content

feat(boto3): Add cloud.provider attribute to boto3 spans - #7884

Merged
pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-add-cloud-provider-attr
Oct 6, 2026
Merged

pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-add-cloud-provider-attr

Conversation

@pabloDeputter

Copy link
Copy Markdown
Contributor

Description

Add cloud.provider (always set aws) to boto3 spans; supplied at span creation time. Already in sentry semcon.

@pabloDeputter
pabloDeputter marked this pull request as ready for review October 6, 2026 11:51
@pabloDeputter
pabloDeputter requested a review from a team as a code owner October 6, 2026 11:51
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 56100 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 58828 | Pass Rate: 95.36% | Execution Time: 157m 16s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -81557
Passed Tests 📉 -77062
Failed Tests —
Skipped Tests 📉 -4495

➕ New Tests (1)

View new tests
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module

❌ Failed Tests

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.13-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2069 uncovered lines.
❌ Project coverage is 90.01%. Comparing base (f5967f5) to head (3c7e221).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.38%    90.01%    -0.37%
==========================================
  Files          202       185       -17
  Lines        26552     20712     -5840
  Branches      9858      7142     -2716
==========================================
+ Hits         23997     18643     -5354
- Misses        2555      2069      -486
- Partials      1487      1202      -285

Generated by Codecov Action

@pabloDeputter
pabloDeputter merged commit 9681060 into major/3.0 Oct 6, 2026
145 of 147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/boto3-add-cloud-provider-attr branch October 6, 2026 11:54
pabloDeputter added a commit that referenced this pull request Oct 6, 2026
### Description
Add
[cloud.provider](https://getsentry.github.io/sentry-conventions/attributes/cloud/#cloud-provider)
(always set `aws`) to boto3 spans; supplied at span creation time.
Already in sentry semcon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants