Skip to content

chore(pydantic-ai): Stop setting gen_ai.request.model on Invoke Agent spans - #7856

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/remove-request-model
Oct 5, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/remove-request-model

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Remove the request model from Invoke Agent spans because it is ambiguous for an agent that can call different models in the course of its execution.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 5, 2026 07:24
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 56844 passed | ⏭️ 2727 skipped | Total: 59571 | Pass Rate: 95.42% | Execution Time: 154m 6s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -80780
Passed Tests 📉 -76285
Failed Tests —
Skipped Tests 📉 -4495

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2072 uncovered lines.

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py 100.00% ⚠️ 1 partials

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/pydantic-ai/remove-request-model branch from de03cbb to 965fbbe Compare October 5, 2026 08:29
@alexander-alderman-webb
alexander-alderman-webb merged commit bf0ad2e into major/3.0 Oct 5, 2026
144 of 145 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/pydantic-ai/remove-request-model branch October 5, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants