Skip to content

chore(pydantic-ai): Stop setting request parameters on Invoke Agent spans - #7855

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/request-attributes
Oct 5, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/request-attributes

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Remove the model request parameters from Invoke Agent spans because the attributes are ambiguous for an agent that can make multiple model calls in the course of its execution.
Each model call may have different request parameters.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 5, 2026 07:19
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 57010 passed | ⏭️ 2727 skipped | Total: 59737 | Pass Rate: 95.43% | Execution Time: 151m 8s

All tests are passing successfully.

❌ Patch coverage is 66.67%. Project has 2077 uncovered lines.
✅ Project coverage is 90.02%. Comparing base (bf0ad2e) to head (95adaef).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py 66.67% ⚠️ 5 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    89.92%    90.02%     +0.1%
==========================================
  Files          193       185        -8
  Lines        24908     20815     -4093
  Branches      8986      7204     -1782
==========================================
+ Hits         22398     18738     -3660
- Misses        2510      2077      -433
- Partials      1430      1206      -224

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 9b7bf29 into major/3.0 Oct 5, 2026
147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/pydantic-ai/request-attributes branch October 5, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants