Skip to content

Clear scope transaction name when span is cleared #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hashim1999164 wants to merge 1 commit into from
Closed

Clear scope transaction name when span is cleared #7846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sentry_sdk/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,6 +904,10 @@ def span(self) -> "Optional[Span]":
@span.setter
def span(self, span: "Optional[Span]") -> None:
self._span = span
if span is None:
self._transaction = None
self._transaction_info = {}
return

@cursor cursor Bot Oct 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphan spans clear transaction names

Medium Severity

Setting span to None now always clears _transaction and _transaction_info. A name stored by set_transaction_name with no active transaction is then dropped when any later span exits and restores None, so later errors lose that name.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f282e26. Configure here.

# XXX: this differs from the implementation in JS, there Scope.setSpan
# does not set Scope._transactionName.
if isinstance(span, Transaction):
Expand Down
3 changes: 3 additions & 0 deletions tests/tracing/test_misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,9 @@ def test_start_transaction_updates_scope_name_source(sentry_init):
assert scope._transaction == "foobar"
assert scope._transaction_info == {"source": "route"}

assert scope._transaction is None
assert scope._transaction_info == {}


@pytest.mark.parametrize("sampled", (True, None))
def test_transaction_dropped_debug_not_started(sentry_init, sampled):
Expand Down