Skip to content

ref(django)!: Drop send_default_pii support in user info collection #7820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
Oct 1, 2026
Merged

ref(django)!: Drop send_default_pii support in user info collection #7820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions sentry_sdk/integrations/django/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
)
from sentry_sdk.integrations.logging import ignore_logger_for_events
from sentry_sdk.integrations.wsgi import SentryWsgiMiddleware
from sentry_sdk.scope import add_global_event_processor, should_send_default_pii
from sentry_sdk.scope import add_global_event_processor
from sentry_sdk.serializer import add_global_repr_processor, add_repr_sequence_type
from sentry_sdk.traces import SegmentNameSource
from sentry_sdk.tracing_utils import (
Expand All @@ -31,7 +31,6 @@
capture_internal_exceptions,
ensure_integration_enabled,
event_from_exception,
has_data_collection_enabled,
walk_exception_chain,
)

Expand Down Expand Up @@ -512,10 +511,7 @@ def _after_get_response(request: "WSGIRequest") -> None:
scope = sentry_sdk.get_current_scope()
_attempt_resolve_again(request, scope)

if has_data_collection_enabled(client.options):
if client.options["data_collection"]["user_info"]:
_get_user_from_request_and_set_on_scope(request)
elif should_send_default_pii():
if client.options["data_collection"]["user_info"]:
_get_user_from_request_and_set_on_scope(request)


Expand Down Expand Up @@ -563,11 +559,7 @@ def wsgi_request_event_processor(event: "Event", hint: "dict[str, Any]") -> "Eve
DjangoRequestExtractor(request).extract_into_event(event)

client_options = sentry_sdk.get_client().options
if has_data_collection_enabled(client_options):
if client_options["data_collection"]["user_info"]:
with capture_internal_exceptions():
_set_user_info(request, event)
elif should_send_default_pii():
if client_options["data_collection"]["user_info"]:
with capture_internal_exceptions():
_set_user_info(request, event)

Expand Down
8 changes: 1 addition & 7 deletions sentry_sdk/integrations/django/asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,10 @@
import sentry_sdk
from sentry_sdk.consts import OP
from sentry_sdk.integrations.asgi import SentryAsgiMiddleware
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.traces import Span
from sentry_sdk.utils import (
capture_internal_exceptions,
ensure_integration_enabled,
has_data_collection_enabled,
)

if TYPE_CHECKING:
Expand Down Expand Up @@ -71,11 +69,7 @@ def asgi_request_event_processor(event: "Event", hint: "dict[str, Any]") -> "Eve
DjangoRequestExtractor(request).extract_into_event(event)

client_options = sentry_sdk.get_client().options
if has_data_collection_enabled(client_options):
if client_options["data_collection"]["user_info"]:
with capture_internal_exceptions():
_set_user_info(request, event)
elif should_send_default_pii():
if client_options["data_collection"]["user_info"]:
with capture_internal_exceptions():
_set_user_info(request, event)

Expand Down
Loading