Skip to content

ref: Simplify - #7809

Merged
sentrivana merged 3 commits into
major/3.0from
ivana/major/simplify
Oct 1, 2026
Merged

sentrivana merged 3 commits into
major/3.0from
ivana/major/simplify

Conversation

@sentrivana

@sentrivana sentrivana commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator
  • inline things to avoid mental context switches
  • use global API

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58925 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 61653 | Pass Rate: 95.58% | Execution Time: 168m 48s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75403
Passed Tests 📉 -70909
Failed Tests 📉 -1
Skipped Tests 📉 -4493

➕ New Tests (1)

View new tests
  • test_spans_from_multiple_threads[propagate_scope=True]
    • File: tests.integrations.threading.test_threading
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_spans_from_multiple_threads[propagate_scope=True]

File: tests.integrations.threading.test_threading
Suite: py3.9-common
Error: AssertionError: assert '82f66af73cec0fb9' == 'a8880b748236b7c3' - a8880b748236b7c3 + 82f66af73cec0fb9

Stack Trace
tests/integrations/threading/test_threading.py:178: in test_spans_from_multiple_threads
    assert span["parent_span_id"] == outer_submit_spans[num].span_id
E   AssertionError: assert '82f66af73cec0fb9' == 'a8880b748236b7c3'
E     
E     - a8880b748236b7c3
E     + 82f66af73cec0fb9

✅ Patch coverage is 100.00%. Project has 2074 uncovered lines.
❌ Project coverage is 90.17%. Comparing base (61a562c) to head (d850d8c).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.17%    -0.17%
==========================================
  Files          199       183       -16
  Lines        26524     21100     -5424
  Branches      9864      7400     -2464
==========================================
+ Hits         23962     19026     -4936
- Misses        2562      2074      -488
- Partials      1495      1230      -265

Generated by Codecov Action

@sentrivana sentrivana changed the title Simplify ref: Simplify Oct 1, 2026
@sentrivana
sentrivana marked this pull request as ready for review October 1, 2026 11:44
@sentrivana
sentrivana requested a review from a team as a code owner October 1, 2026 11:44

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d850d8c. Configure here.

@sentrivana

Copy link
Copy Markdown
Collaborator Author

Tiny change with no behavioral effect, I'll just merge

@sentrivana
sentrivana merged commit e781015 into major/3.0 Oct 1, 2026
144 of 147 checks passed
@sentrivana
sentrivana deleted the ivana/major/simplify branch October 1, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant