Skip to content

ref(quart): Remove transaction_style parameter - #7805

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/quart/transaction-style
Oct 1, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/quart/transaction-style

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Inline the branches that set the route template as the segment name (i.e., transaction_style="url").

Issues

Closes #7764

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 09:53

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c2c18a6. Configure here.

Comment thread sentry_sdk/integrations/quart.py Resolved
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58467 passed | ❌ 1 failed | ⏭️ 2727 skipped | Total: 61195 | Pass Rate: 95.54% | Execution Time: 160m 54s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75861
Passed Tests 📉 -71367
Failed Tests 📉 -1
Skipped Tests 📉 -4493

➕ New Tests (1)

View new tests
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

❌ Patch coverage is 60.00%. Project has 2073 uncovered lines.
❌ Project coverage is 90.17%. Comparing base (07db984) to head (e49dd51).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/quart.py 60.00% ⚠️ 2 Missing
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.17%    -0.17%
==========================================
  Files          199       183       -16
  Lines        26524     21092     -5432
  Branches      9864      7400     -2464
==========================================
+ Hits         23962     19019     -4943
- Misses        2562      2073      -489
- Partials      1495      1229      -266

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 39d6006 into major/3.0 Oct 1, 2026
144 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/quart/transaction-style branch October 1, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants