Skip to content

ref(falcon): Remove transaction_style parameter - #7804

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/falcon/transaction-style
Oct 1, 2026
Merged

alexander-alderman-webb merged 1 commit into
major/3.0from
webb/falcon/transaction-style

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Inline the branches that set the route template as the segment name (i.e., transaction_style="uri_template").

Issues

Closes #7757

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 1, 2026 09:32
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 09:32
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 57858 passed | ❌ 3 failed | ⏭️ 2709 skipped | Total: 60570 | Pass Rate: 95.52% | Execution Time: 163m 40s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -76486
Passed Tests 📉 -71976
Failed Tests 📈 +1
Skipped Tests 📉 -4511

➕ New Tests (3)

View new tests
  • test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.6.0
Error: KeyError: 140272896851968

Stack Trace
tests/integrations/mistral/test_mistral.py:389: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140272896851968

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.12-django-v6.1.1
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.13-django-v5.2.17
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00%. Project has 2064 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (629f642) to head (3fe0ce8).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.35%    90.10%    -0.25%
==========================================
  Files          199       179       -20
  Lines        26524     20838     -5686
  Branches      9864      7340     -2524
==========================================
+ Hits         23962     18774     -5188
- Misses        2562      2064      -498
- Partials      1495      1221      -274

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 11fb9aa into major/3.0 Oct 1, 2026
142 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/falcon/transaction-style branch October 1, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants