Skip to content

ref(bottle): Remove transaction_style parameter - #7803

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/bottle/transaction-style
Oct 1, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/bottle/transaction-style

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Inline the branches that set the route template as the segment name (i.e., transaction_style="url").

Issues

Closes #7758

Reminders

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bottle/transaction-style branch from d3279ca to 01d42ff Compare October 1, 2026 09:15
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58075 passed | ❌ 3 failed | ⏭️ 2709 skipped | Total: 60787 | Pass Rate: 95.54% | Execution Time: 159m 57s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -76269
Passed Tests 📉 -71759
Failed Tests 📈 +1
Skipped Tests 📉 -4511

➕ New Tests (3)

View new tests
  • test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_cache_spans_decorator
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_async_transport_rate_limiting_with_concurrency
    • File: tests.test_transport
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.6.0
Error: KeyError: 139930343563264

Stack Trace
tests/integrations/mistral/test_mistral.py:389: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139930343563264

test_cache_spans_decorator

File: tests.integrations.django.test_cache_module
Suite: py3.11-django-v4.2.30
Error: tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:307: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_async_transport_rate_limiting_with_concurrency

File: tests.test_transport
Suite: py3.8-common
Error: AssertionError: assert False is True + where False = _check_disabled('error') + where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f6a40654730>._check_disabled + where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f6a40654730> = <sentry_sdk.client._Client object at 0x7f6a30d84ee0>.transport

Stack Trace
tests/test_transport.py:1037: in test_async_transport_rate_limiting_with_concurrency
    assert client.transport._check_disabled("error") is True
E   AssertionError: assert False is True
E    +  where False = _check_disabled('error')
E    +    where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f6a40654730>._check_disabled
E    +      where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f6a40654730> = <sentry_sdk.client._Client object at 0x7f6a30d84ee0>.transport

✅ Patch coverage is 100.00%. Project has 2064 uncovered lines.
❌ Project coverage is 90.09%. Comparing base (629f642) to head (10f58a9).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/bottle.py 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.09%    -0.25%
==========================================
  Files          199       179       -20
  Lines        26524     20837     -5687
  Branches      9864      7338     -2526
==========================================
+ Hits         23962     18773     -5189
- Misses        2562      2064      -498
- Partials      1495      1221      -274

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title ref(bottle): Remove transaction_style parameter ref(bottle): Remove transaction_style parameter Oct 1, 2026
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 1, 2026 09:32
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 09:32
@alexander-alderman-webb
alexander-alderman-webb merged commit 7f1d3f7 into major/3.0 Oct 1, 2026
142 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bottle/transaction-style branch October 1, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants