Skip to content

ref(django): Remove transaction_style parameter - #7799

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/django/transaction-style
Oct 1, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/django/transaction-style

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Inline the branches that set the route template as the segment name (i.e., transaction_style="url").

Issues

Closes #7763

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review October 1, 2026 08:53
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner October 1, 2026 08:53
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58076 passed | ❌ 3 failed | ⏭️ 2709 skipped | Total: 60788 | Pass Rate: 95.54% | Execution Time: 162m 32s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -76268
Passed Tests 📉 -71758
Failed Tests 📈 +1
Skipped Tests 📉 -4511

➕ New Tests (2)

View new tests
  • test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_async_transport_rate_limiting_with_concurrency
    • File: tests.test_transport
    • Status: ❌ Failing

➖ Removed Tests (1)

View removed tests
  • test_binary_content_encoding_image_url[True-False]
    • File: tests.integrations.litellm.test_litellm

❌ Failed Tests

test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.6.0
Error: KeyError: 140353409462720

Stack Trace
tests/integrations/mistral/test_mistral.py:389: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140353409462720

test_async_transport_rate_limiting_with_concurrency

File: tests.test_transport
Suite: py3.8-common
Error: AssertionError: assert False is True + where False = _check_disabled('error') + where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f2b80096100>._check_disabled + where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f2b80096100> = <sentry_sdk.client._Client object at 0x7f2b60c1cb50>.transport

Stack Trace
tests/test_transport.py:1037: in test_async_transport_rate_limiting_with_concurrency
    assert client.transport._check_disabled("error") is True
E   AssertionError: assert False is True
E    +  where False = _check_disabled('error')
E    +    where _check_disabled = <sentry_sdk.transport.AsyncHttpTransport object at 0x7f2b80096100>._check_disabled
E    +      where <sentry_sdk.transport.AsyncHttpTransport object at 0x7f2b80096100> = <sentry_sdk.client._Client object at 0x7f2b60c1cb50>.transport

✅ Patch coverage is 100.00%. Project has 2054 uncovered lines.
❌ Project coverage is 90.14%. Comparing base (629f642) to head (4d50ceb).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/django/init.py 100.00% ⚠️ 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.34%    90.14%     -0.2%
==========================================
  Files          199       179       -20
  Lines        26524     20826     -5698
  Branches      9864      7330     -2534
==========================================
+ Hits         23962     18772     -5190
- Misses        2562      2054      -508
- Partials      1495      1220      -275

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 10ed892 into major/3.0 Oct 1, 2026
142 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/django/transaction-style branch October 1, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants