Skip to content

ref(typesafe): Drop send_default_pii support - #7754

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/typesafe-drop-send-default-pii
Sep 29, 2026
Merged

alexander-alderman-webb merged 1 commit into
major/3.0from
webb/typesafe-drop-send-default-pii

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Description

The inputs part was already completed in a prior merge from main.

Issues

Closes #7752

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 29, 2026 12:26
@alexander-alderman-webb
alexander-alderman-webb merged commit 40d19b3 into major/3.0 Sep 29, 2026
144 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/typesafe-drop-send-default-pii branch September 29, 2026 12:34
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 57428 passed | ❌ 2 failed | ⏭️ 2729 skipped | Total: 60159 | Pass Rate: 95.46% | Execution Time: 166m 49s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -76700
Passed Tests 📉 -72262
Failed Tests 📈 +2
Skipped Tests 📉 -4440

➕ New Tests (2)

View new tests
  • test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing
  • test_cache_spans_item_size
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.6.0
Error: KeyError: 139716645662720

Stack Trace
tests/integrations/mistral/test_mistral.py:389: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139716645662720

test_cache_spans_item_size

File: tests.integrations.django.test_cache_module
Suite: py3.14t-django-v6.1.1
Error: tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:546: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

❌ Patch coverage is 66.67%. Project has 2069 uncovered lines.
❌ Project coverage is 90.06%. Comparing base (b0bd42f) to head (f312233).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/typesafe.py 66.67% ⚠️ 2 Missing and 2 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.06%    -0.22%
==========================================
  Files          195       179       -16
  Lines        26195     20809     -5386
  Branches      9758      7322     -2436
==========================================
+ Hits         23649     18740     -4909
- Misses        2546      2069      -477
- Partials      1483      1219      -264

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants