Repository navigation
ref(mcp): Drop send_default_pii support - #7747
Conversation
Codecov Results 📊✅ 57650 passed | ❌ 2 failed | ⏭️ 2729 skipped | Total: 60381 | Pass Rate: 95.48% | Execution Time: 165m 22s 📊 Comparison with Base Branch
➕ New Tests (2)View new tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/mcp.py | 100.00% |
Coverage diff
@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.28% 90.05% -0.23%
==========================================
Files 195 179 -16
Lines 26195 20780 -5415
Branches 9758 7302 -2456
==========================================
+ Hits 23649 18712 -4937
- Misses 2546 2068 -478
- Partials 1483 1213 -270Generated by Codecov Action
sentrivana
left a comment
There was a problem hiding this comment.
Please double check the removed data collection tests here too if you haven't yet
Remove
send_default_piibranches from the integration.Add the
data_collectionoption to all tests for the integration, withgen_aioptions enabled ifsend_default_piiwasTrue, andgen_aioptions disabled ifsend_default_piiwasFalse. Whensend_default_piiwas previously not supplied tosentry_init(), providedata_collection={}.Split tests that were parametrized on
send_default_piiinto two non-parametrized tests, withgen_aioptions enabled and disabled (the latter suffixed with_no_sensitive_data).Remove data collection specific tests, as existing tests now exercise the same code paths.
Closes #7600