Skip to content

ref(pydantic-ai): Drop send_default_pii support - #7746

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/drop-send-default-pii
Sep 29, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/pydantic-ai/drop-send-default-pii

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Remove send_default_pii branches from the integration.

Add the data_collection option to all tests for the integration, with gen_ai options enabled if send_default_pii was True, and gen_ai options disabled if send_default_pii was False. When send_default_pii was previously not supplied to sentry_init(), provide data_collection={}.

Split tests that were parametrized on send_default_pii into two non-parametrized tests, with gen_ai options enabled and disabled (the latter suffixed with _no_sensitive_data).

Remove cases of _data_collection tests that are exercised by existing tests now.

Closes #7604

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 58787 passed | ❌ 1 failed | ⏭️ 2729 skipped | Total: 61517 | Pass Rate: 95.56% | Execution Time: 166m 24s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -75342
Passed Tests 📉 -70903
Failed Tests 📈 +1
Skipped Tests 📉 -4440

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140249337397248

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140249337397248

✅ Patch coverage is 100.00%. Project has 2069 uncovered lines.
❌ Project coverage is 90.08%. Comparing base (21c9144) to head (b5aafb1).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py 100.00% ⚠️ 8 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.08%     -0.2%
==========================================
  Files          195       179       -16
  Lines        26195     20855     -5340
  Branches      9758      7384     -2374
==========================================
+ Hits         23649     18786     -4863
- Misses        2546      2069      -477
- Partials      1483      1213      -270

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 29, 2026 09:39
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 29, 2026 09:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e1f3564. Configure here.

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please check if we're not losing anything by removing test_data_collection_gen_ai_inputs_gates_request_messages_tool_inputs_and_available_tools and test_data_collection_gen_ai_outputs_gates_response_text_and_tool_outputs if you haven't already

@alexander-alderman-webb
alexander-alderman-webb merged commit 38385c5 into major/3.0 Sep 29, 2026
145 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/pydantic-ai/drop-send-default-pii branch September 29, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants