Repository navigation
ref(pydantic-ai): Drop send_default_pii support - #7746
Conversation
Codecov Results 📊✅ 58787 passed | ❌ 1 failed | ⏭️ 2729 skipped | Total: 61517 | Pass Rate: 95.56% | Execution Time: 166m 24s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py | 100.00% |
Coverage diff
@@ Coverage Diff @@
## master #PR +/-##
==========================================
- Coverage 90.28% 90.08% -0.2%
==========================================
Files 195 179 -16
Lines 26195 20855 -5340
Branches 9758 7384 -2374
==========================================
+ Hits 23649 18786 -4863
- Misses 2546 2069 -477
- Partials 1483 1213 -270Generated by Codecov Action
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e1f3564. Configure here.
sentrivana
left a comment
There was a problem hiding this comment.
LGTM, please check if we're not losing anything by removing test_data_collection_gen_ai_inputs_gates_request_messages_tool_inputs_and_available_tools and test_data_collection_gen_ai_outputs_gates_response_text_and_tool_outputs if you haven't already

Remove
send_default_piibranches from the integration.Add the
data_collectionoption to all tests for the integration, withgen_aioptions enabled ifsend_default_piiwasTrue, andgen_aioptions disabled ifsend_default_piiwasFalse. Whensend_default_piiwas previously not supplied tosentry_init(), providedata_collection={}.Split tests that were parametrized on
send_default_piiinto two non-parametrized tests, withgen_aioptions enabled and disabled (the latter suffixed with_no_sensitive_data).Remove cases of
_data_collectiontests that are exercised by existing tests now.Closes #7604