[alexander-alderman-webb]

Remove send_default_pii branches from the integration.

Add the data_collection option to all tests for the integration, with gen_ai options enabled if send_default_pii was True, and gen_ai options disabled if send_default_pii was False. When send_default_pii was previously not supplied to sentry_init(), provide data_collection={}.

Split tests that were parametrized on send_default_pii into two non-parametrized tests, with gen_ai options enabled and disabled (the latter suffixed with _no_sensitive_data).

Remove data collection specific tests, as existing tests now exercise the same code paths.

Closes #7603

[github-actions]

Codecov Results 📊

✅ 58682 passed | ❌ 2 failed | ⏭️ 2729 skipped | Total: 61413 | Pass Rate: 95.55% | Execution Time: 165m 33s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -75446
Passed Tests	📉 -71008
Failed Tests	📈 +2
Skipped Tests	📉 -4440

➕ New Tests (2)

View new tests

• test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
  • File: tests.integrations.mistral.test_mistral
  • Status: ❌ Failing
• test_spans_from_multiple_threads[propagate_scope=True]
  • File: tests.integrations.threading.test_threading
  • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140251938033664

Stack Trace

tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140251938033664

test_spans_from_multiple_threads[propagate_scope=True]

File: tests.integrations.threading.test_threading
Suite: py3.9-common
Error: AssertionError: assert '933adc661413f5c9' == 'bd24405555b2d639' - bd24405555b2d639 + 933adc661413f5c9

Stack Trace

tests/integrations/threading/test_threading.py:178: in test_spans_from_multiple_threads
    assert span["parent_span_id"] == outer_submit_spans[num].span_id
E   AssertionError: assert '933adc661413f5c9' == 'bd24405555b2d639'
E     
E     - bd24405555b2d639
E     + 933adc661413f5c9

✅ Patch coverage is 100.00%. Project has 2073 uncovered lines.
❌ Project coverage is 90.06%. Comparing base (21c9144) to head (edde9e5).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.06%    -0.22%
==========================================
  Files          195       179       -16
  Lines        26195     20862     -5333
  Branches      9758      7382     -2376
==========================================
+ Hits         23649     18789     -4860
- Misses        2546      2073      -473
- Partials      1483      1218      -265

---

Generated by Codecov Action

[sentrivana]

Looks good but please also double check the removed tests if you haven't already 🙏🏻