[alexander-alderman-webb]

Remove send_default_pii branches from the integration.

Add the data_collection option to all tests for the integration, with gen_ai options enabled if send_default_pii was True, and gen_ai options disabled if send_default_pii was False. When send_default_pii was previously not supplied to sentry_init(), provide data_collection={}.

Split tests that were parametrized on send_default_pii into two non-parametrized tests, with gen_ai options enabled and disabled (the latter suffixed with _no_sensitive_data).

Remove cases of _data_collection tests that are exercised by existing tests now.

Closes #7598

[github-actions]

Codecov Results 📊

✅ 59981 passed | ❌ 1 failed | ⏭️ 2741 skipped | Total: 62723 | Pass Rate: 95.63% | Execution Time: 164m 46s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -74136
Passed Tests	📉 -69709
Failed Tests	📈 +1
Skipped Tests	📉 -4428

➕ New Tests (1)

View new tests

• test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
  • File: tests.integrations.mistral.test_mistral
  • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139697627086848

Stack Trace

tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:217: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139697627086848

✅ Patch coverage is 100.00%. Project has 2070 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (21c9144) to head (a95d958).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.28%    90.10%    -0.18%
==========================================
  Files          195       179       -16
  Lines        26195     20915     -5280
  Branches      9758      7428     -2330
==========================================
+ Hits         23649     18845     -4804
- Misses        2546      2070      -476
- Partials      1483      1209      -274

---

Generated by Codecov Action

[sentrivana]

This and test_embeddings_data_collection also look like they'd be useful to keep?

[alexander-alderman-webb]

test_embeddings_data_collection is equivalent to test_embeddings_create and test_embeddings_no_pii (renamed to test_embeddings_no_sensitive_data()).

I've restored parts of the chat completions test: 2090d14

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2090d14. Configure here.}