ref(rq): Drop `send_default_pii` support by pabloDeputter · Pull Request #7729 · getsentry/sentry-python

pabloDeputter · 2026-09-28T11:49:33Z

Description

Drop send_default_pii support for RQ integration.

Issues

Resolves #7609

github-actions · 2026-09-28T11:56:16Z

Codecov Results 📊

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -68480
Passed Tests	📉 -64163
Failed Tests	📉 -46
Skipped Tests	📉 -4271

➕ New Tests (13)

View new tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_sets_new_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_uses_existing_tracer_provider_with_otlp_exporter
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_sets_endpoint
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing
test_collector_url_none_falls_back_to_dsn
- File: tests.integrations.otlp.test_otlp
- Status: ❌ Failing

➖ Removed Tests (59)

View removed tests

test_input_attributes_nonstreaming_chat[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[True-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-True-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-True-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages0-expected_system_instructions0-expected_input_messages0]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages1-expected_system_instructions1-expected_input_messages1]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages2-expected_system_instructions2-expected_input_messages2]
- File: tests.integrations.mistral.test_mistral
test_input_attributes_nonstreaming_chat_async[False-False-False-messages3-expected_system_instructions3-expected_input_messages3]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat[False-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[True-False-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-True-False]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-True]
- File: tests.integrations.mistral.test_mistral
test_output_attributes_nonstreaming_chat_async[False-False-False]
- File: tests.integrations.mistral.test_mistral

❌ Failed Tests

`test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]`

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140636374786048

Stack Trace

tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140636374786048

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.12-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.13-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_sets_new_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:84: in test_sets_new_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_uses_existing_tracer_provider_with_otlp_exporter`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:113: in test_uses_existing_tracer_provider_with_otlp_exporter
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_sets_endpoint`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:259: in test_collector_url_sets_endpoint
    assert exporter._headers is None or "X-Sentry-Auth" not in exporter._headers
           ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

`test_collector_url_none_falls_back_to_dsn`

File: tests.integrations.otlp.test_otlp
Suite: py3.14-otlp
Error: AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

Stack Trace

tests/integrations/otlp/test_otlp.py:300: in test_collector_url_none_falls_back_to_dsn
    assert "X-Sentry-Auth" in exporter._headers
                              ^^^^^^^^^^^^^^^^^
E   AttributeError: 'OTLPSpanExporter' object has no attribute '_headers'

✅ Patch coverage is 100.00%. Project has 2071 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (609ccad) to head (5bb9330).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.10%    -0.12%
==========================================
  Files          195       178       -17
  Lines        26101     20918     -5183
  Branches      9694      7498     -2196
==========================================
+ Hits         23548     18847     -4701
- Misses        2553      2071      -482
- Partials      1461      1187      -274

Generated by Codecov Action

sentrivana

Please also add data_collection={} to the remaining tests, too, so that we make sure we're testing the default data collection.

pabloDeputter · 2026-09-28T12:08:20Z

ok, I thought we should only add it to tests that assert on data-collection/sensitive output.

pabloDeputter added 2 commits September 28, 2026 13:44

ref(rq): Drop send_default_pii support

27e891b

tests(rq): Drop send_default_pii support

92a9d0a

pabloDeputter marked this pull request as ready for review September 28, 2026 12:02

pabloDeputter requested a review from a team as a code owner September 28, 2026 12:02

sentrivana approved these changes Sep 28, 2026

View reviewed changes

pabloDeputter added 2 commits September 28, 2026 14:16

tests(rq): Add data_collection={} to tests

ffd5e8c

ref(tests): Add data_collection={} to remaining tests

5bb9330

pabloDeputter merged commit 90addee into major/3.0 Sep 28, 2026
138 of 145 checks passed

pabloDeputter deleted the pablo/rq-drop-pii branch September 28, 2026 12:28

Navigation Menu

Repository navigation

ref(rq): Drop `send_default_pii` support - #7729

ref(rq): Drop `send_default_pii` support#7729
pabloDeputter merged 4 commits into
major/3.0from
pablo/rq-drop-pii

pabloDeputter commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

sentrivana left a comment

Uh oh!

pabloDeputter commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pabloDeputter commented Sep 28, 2026

Description

Issues

Uh oh!

github-actions Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

➕ New Tests (13)

➖ Removed Tests (59)

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

test_sets_new_tracer_provider_with_otlp_exporter

test_uses_existing_tracer_provider_with_otlp_exporter

test_collector_url_sets_endpoint

test_collector_url_none_falls_back_to_dsn

Uh oh!

sentrivana left a comment

Choose a reason for hiding this comment

Uh oh!

pabloDeputter commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 28, 2026 •

edited

Loading

`test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`

`test_sets_new_tracer_provider_with_otlp_exporter`

`test_uses_existing_tracer_provider_with_otlp_exporter`

`test_collector_url_sets_endpoint`

`test_collector_url_none_falls_back_to_dsn`