Skip to content

tests(aiohttp): Drop send_default_pii support in tests - #7711

Merged
pabloDeputter merged 1 commit into
major/3.0from
pablo/aiohttp-drop-pii
Sep 25, 2026
Merged

pabloDeputter merged 1 commit into
major/3.0from
pablo/aiohttp-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 62941 passed | ❌ 1 failed | ⏭️ 2890 skipped | Total: 65832 | Pass Rate: 95.61% | Execution Time: 174m 43s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -71222
Passed Tests 📉 -66961
Failed Tests 📈 +1
Skipped Tests 📉 -4262

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140145990819840

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140145990819840

✅ Patch coverage is 100.00%. Project has 2066 uncovered lines.
❌ Project coverage is 90.16%. Comparing base (0fbf5bf) to head (2ec139a).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.20%    90.16%    -0.04%
==========================================
  Files          194       178       -16
  Lines        26030     20998     -5032
  Branches      9678      7574     -2104
==========================================
+ Hits         23480     18932     -4548
- Misses        2550      2066      -484
- Partials      1454      1196      -258

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 25, 2026 10:27
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 25, 2026 10:27

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@pabloDeputter
pabloDeputter merged commit cf47bad into major/3.0 Sep 25, 2026
145 of 147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/aiohttp-drop-pii branch September 25, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants