Skip to content

ref(boto3): Drop send_default_pii support - #7684

Merged
pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-drop-pii
Sep 23, 2026
Merged

pabloDeputter merged 4 commits into
major/3.0from
pablo/boto3-drop-pii

Conversation

@pabloDeputter

Copy link
Copy Markdown
Contributor

Description

  • remove send_default_pii branching in tests_s3.py.
  • Remove send_default_pii fallback from tracing_utils.get_url_attributes()

Issues

Resolves #7658

@pabloDeputter
pabloDeputter changed the base branch from master to major/3.0 September 23, 2026 13:13
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 65150 passed | ❌ 1 failed | ⏭️ 2971 skipped | Total: 68122 | Pass Rate: 95.64% | Execution Time: 191m 1s

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139867268526080

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139867268526080

✅ Patch coverage is 91.67%. Project has 2064 uncovered lines.
✅ Project coverage is 90.21%. Comparing base (e5880eb) to head (36f8250).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/tracing_utils.py 88.24% ⚠️ 2 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.21%    90.21%        —%
==========================================
  Files          194       180       -14
  Lines        25997     21092     -4905
  Branches      9662      7604     -2058
==========================================
+ Hits         23454     19028     -4426
- Misses        2543      2064      -479
- Partials      1451      1198      -253

Generated by Codecov Action

@pabloDeputter
pabloDeputter marked this pull request as ready for review September 23, 2026 14:00
@pabloDeputter
pabloDeputter requested a review from a team as a code owner September 23, 2026 14:00
@pabloDeputter
pabloDeputter merged commit a1913eb into major/3.0 Sep 23, 2026
145 of 147 checks passed
@pabloDeputter
pabloDeputter deleted the pablo/boto3-drop-pii branch September 23, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove send_default_pii from boto3

2 participants