Skip to content

ref(clickhouse): Drop support for send_default_pii #7683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 3 commits into from
Sep 23, 2026
Merged

ref(clickhouse): Drop support for send_default_pii #7683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15c331b
ref(clickhouse): Drop support for `send_default_pii`
sentrivana Sep 23, 2026
8b9c392
old comment
sentrivana Sep 23, 2026
cb46707
Merge branch 'major/3.0' into ivana/major/drop-pii-clickhouse
sentrivana Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions sentry_sdk/integrations/clickhouse_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@
import sentry_sdk
from sentry_sdk.consts import OP, SPANDATA
from sentry_sdk.integrations import DidNotEnable, Integration, _check_minimum_version
from sentry_sdk.scope import should_send_default_pii
from sentry_sdk.traces import Span
from sentry_sdk.utils import has_data_collection_enabled

# Hack to get new Python features working in older versions
# without introducing a hard dependency on `typing_extensions`
Expand Down Expand Up @@ -125,13 +123,7 @@ def _inner_end(*args: "P.args", **kwargs: "P.kwargs") -> "T":

if query is not None and breadcrumb_data is not None:
client_options = sentry_sdk.get_client().options
if (
has_data_collection_enabled(client_options)
and client_options["data_collection"]["database_query_data"]
) or (
not has_data_collection_enabled(client_options)
and should_send_default_pii()
):
if client_options["data_collection"]["database_query_data"]:
breadcrumb_data = {"db.result": res, **breadcrumb_data}

sentry_sdk.get_isolation_scope().add_breadcrumb(
Expand Down
Loading
Loading