Skip to content

chore(mcp): Remove include_prompts parameter - #7680

Merged
alexander-alderman-webb merged 1 commit into
major/3.0from
webb/mcp/remove-include-prompts
Sep 23, 2026
Merged

alexander-alderman-webb merged 1 commit into
major/3.0from
webb/mcp/remove-include-prompts

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Collaborator

Description

Remove the include_prompts parameter. The parameter allowed users to opt-out of collecting GenAI attributes while keeping send_default_pii=True. The parameter is ignored when data collection is used, and the major is dropping send_default_pii in favor of data collection.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 23, 2026 12:26
@alexander-alderman-webb alexander-alderman-webb changed the title chore(mcp): Remove include_prompts parameter chore(mcp): Remove include_prompts parameter Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 65355 passed | ❌ 1 failed | ⏭️ 2971 skipped | Total: 68327 | Pass Rate: 95.65% | Execution Time: 185m 48s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -69379
Passed Tests 📉 -65229
Failed Tests 📈 +1
Skipped Tests 📉 -4151

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 139626285436928

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 139626285436928

✅ Patch coverage is 100.00%. Project has 2089 uncovered lines.
❌ Project coverage is 90.1%. Comparing base (0dbe856) to head (51d25aa).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.10%    -0.12%
==========================================
  Files          194       180       -14
  Lines        25997     21101     -4896
  Branches      9662      7624     -2038
==========================================
+ Hits         23454     19012     -4442
- Misses        2543      2089      -454
- Partials      1451      1197      -254

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit 0b709cf into major/3.0 Sep 23, 2026
145 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mcp/remove-include-prompts branch September 23, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants