[sentrivana]

There's a data_collection version of the removed tests.

Closes https://linear.app/getsentry/issue/PY-2810/remove-send-default-pii-from-ariadne

[linear-code]

PY-2810

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d384e14. Configure here.}

[cursor]

Responses collected without PII opt-in

High Severity

GraphQL error responses are now attached whenever outgoing_response is in http_bodies. If data_collection is unset, that list is always fully populated, so responses that used to require send_default_pii are sent by default and can include query result data.

 

^{Reviewed by Cursor Bugbot for commit d384e14. Configure here.}

[github-actions]

Codecov Results 📊

✅ 66800 passed | ❌ 1 failed | ⏭️ 3019 skipped | Total: 69820 | Pass Rate: 95.67% | Execution Time: 193m 5s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📉 -67886
Passed Tests	📉 -63784
Failed Tests	📈 +1
Skipped Tests	📉 -4103

➕ New Tests (1)

View new tests

• test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
  • File: tests.integrations.mistral.test_mistral
  • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140460641832960

Stack Trace

tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140460641832960

✅ Patch coverage is 100.00%. Project has 2086 uncovered lines.
❌ Project coverage is 90.13%. Comparing base (719a46b) to head (d384e14).

Coverage diff

@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.22%    90.13%    -0.09%
==========================================
  Files          194       180       -14
  Lines        25997     21135     -4862
  Branches      9662      7644     -2018
==========================================
+ Hits         23454     19049     -4405
- Misses        2543      2086      -457
- Partials      1451      1200      -251

---

Generated by Codecov Action