Repository navigation
chore: Deprecate include_prompts parameters - #7625
alexander-alderman-webb wants to merge 1 commit into
Conversation
alexander-alderman-webb
changed the title
include_prompts parameters
ee50f02 to
8d3e5ab
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
8d3e5ab to
655fe33
Compare
sentrivana
left a comment
sentrivana
left a comment
There was a problem hiding this comment.
I'm not sure if we should deprecate like this. I worry that users will just use the snippet we mention (data_collection={'gen_ai': {'inputs': False, 'outputs': False}}), and in doing that, they'll unknowingly start sending more data than they'd expect as the defaults of data_collection are quite permissive and their event_scrubber will silently stop working. Both of those behavior changes are pretty disruptive and hidden.
Basically, the switch from using include_prompts to data_collection hides the complexity of migrating from send_default_pii to data_collection.
What we can do:
- Still emit the deprecation warning (after all, we're not forcing folks to switch to
data_collectionimmediately;include_promptswill still continue to work), but make the message clearer that more care is needed when migrating todata_collection. A link to the docs would also be great.
- Let's use the new
deprecation_warningfunc from utils if we want to keep the warning.
- Don't emit the deprecation warning at all.
655fe33 to
2500197
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2500197. Configure here.
|
Yeah that makes sense. |
Codecov Results 📊✅ 117179 passed | ❌ 96 failed | ⏭️ 6574 skipped | Total: 123849 | Pass Rate: 94.61% | Execution Time: 434m 35s 📊 Comparison with Base Branch
➕ New Tests (96)View new tests
➖ Removed Tests (1)View removed tests
❌ Failed Tests
|
| File | Patch % | Lines |
|---|---|---|
| sentry_sdk/integrations/cohere.py | 100.00% | |
| sentry_sdk/integrations/langchain.py | 100.00% |
Coverage diff
@@ Coverage Diff @@
## master #PR +/-##
==========================================
+ Coverage 90.22% 90.23% +0.01%
==========================================
Files 194 194 —
Lines 25997 26026 +29
Branches 9662 9682 +20
==========================================
+ Hits 23454 23484 +30
- Misses 2543 2542 -1
- Partials 1451 1452 +1Generated by Codecov Action
Description
Deprecate
include_promptsbecause data collection will be the single source of truth for gating sensitive GenAI data in the upcoming major.Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)