Skip to content

ref(openai-agents): Remove workflow spans - #7563

Merged
alexander-alderman-webb merged 2 commits into
major/3.0from
webb/openai-agents/remove-handoff-span
Sep 23, 2026
Merged

alexander-alderman-webb merged 2 commits into
major/3.0from
webb/openai-agents/remove-handoff-span

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Remove workflow spans since the product does not support them.

There is no need to have agents under a common transaction in span first, since agents that hand off to each other share the same trace ID in the streaming trace lifecycle (sibling agent invocation spans).

Remove test_multiple_agents_asyncio(), test_no_conversation_id_when_not_provided(), test_runner_run_with_starting_agent_kwarg() and test_runner_run_streamed_with_starting_agent_kwarg() since they only have assertions on workflow spans.

Issues

Reminders

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review September 22, 2026 07:22
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner September 22, 2026 07:22
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 64470 passed | ❌ 1 failed | ⏭️ 2899 skipped | Total: 67370 | Pass Rate: 95.7% | Execution Time: 183m 41s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -70336
Passed Tests 📉 -66114
Failed Tests 📈 +1
Skipped Tests 📉 -4223

➕ New Tests (1)

View new tests
  • test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]
    • File: tests.integrations.mistral.test_mistral
    • Status: ❌ Failing

❌ Failed Tests

test_input_attributes_nonstreaming_chat[True-messages0-expected_system_instructions0-expected_input_messages0]

File: tests.integrations.mistral.test_mistral
Suite: py3.10-mistral-v2.0.5
Error: KeyError: 140425740218368

Stack Trace
tests/integrations/mistral/test_mistral.py:380: in test_input_attributes_nonstreaming_chat
    sentry_init(
tests/conftest.py:349: in inner
    client = sentry_sdk.Client(*a, **kw)
sentry_sdk/client.py:278: in __init__
    self._init_impl()
sentry_sdk/client.py:428: in _init_impl
    self.integrations = setup_integrations(
sentry_sdk/integrations/__init__.py:216: in setup_integrations
    for integration_cls in iter_default_integrations(
sentry_sdk/integrations/__init__.py:44: in iter_default_integrations
    yield getattr(import_module(module), cls)
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
<frozen importlib._bootstrap>:1050: in _gcd_import
    ???
<frozen importlib._bootstrap>:1024: in _find_and_load
    ???
<frozen importlib._bootstrap>:171: in __enter__
    ???
<frozen importlib._bootstrap>:123: in acquire
    ???
E   KeyError: 140425740218368

❌ Patch coverage is 71.88%. Project has 2057 uncovered lines.
✅ Project coverage is 90.2%. Comparing base (96a7ac8) to head (53cfeab).

Files with missing lines (2)
File Patch % Lines
sentry_sdk/integrations/openai_agents/patches/runner.py 74.19% ⚠️ 8 Missing and 4 partials
sentry_sdk/integrations/openai_agents/patches/agent_run.py 0.00% ⚠️ 1 Missing
Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
+ Coverage    90.20%    90.20%        —%
==========================================
  Files          193       179       -14
  Lines        25788     20998     -4790
  Branches      9530      7578     -1952
==========================================
+ Hits         23261     18941     -4320
- Misses        2527      2057      -470
- Partials      1432      1197      -235

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb merged commit e9ab737 into major/3.0 Sep 23, 2026
145 of 147 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/openai-agents/remove-handoff-span branch September 23, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants