Skip to content

chore: Migrate even more tests - #7482

Merged
sentrivana merged 5 commits into
major/3.0from
ivana/major/more-tests-ofc
Sep 14, 2026
Merged

sentrivana merged 5 commits into
major/3.0from
ivana/major/more-tests-ofc

Conversation

@sentrivana

@sentrivana sentrivana commented Sep 11, 2026 •

Copy link
Copy Markdown
Collaborator
  • remove transaction events from tests (replace with other event types if necessary)
  • remove transaction helpers from conftest
  • remove tests that assert on us emitting warnings if using incompatible api (streaming/non-streaming)
  • remove tests that test _experiments/top-level option precedence for span streaming options (options not available in _experiments anymore)
  • some args reformatting

@sentrivana
sentrivana marked this pull request as ready for review September 11, 2026 14:41
@sentrivana
sentrivana requested a review from a team as a code owner September 11, 2026 14:41

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2330477. Configure here.

Comment thread tests/test_client.py Resolved
Comment thread tests/test_transport.py Resolved
@sentrivana
sentrivana marked this pull request as draft September 11, 2026 14:44
@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 67042 passed | ⏭️ 3304 skipped | Total: 70346 | Pass Rate: 95.3% | Execution Time: 213m 34s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -63385
Passed Tests 📉 -59558
Failed Tests —
Skipped Tests 📉 -3827

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2754 uncovered lines.
❌ Project coverage is 87.65%. Comparing base (9a5e80e) to head (90b2ce5).

Coverage diff
@@            Coverage Diff             @@
##        master       #PR       +/-##
==========================================
- Coverage    90.18%    87.65%    -2.53%
==========================================
  Files          193       181       -12
  Lines        25790     22296     -3494
  Branches      9532      8100     -1432
==========================================
+ Hits         23258     19542     -3716
- Misses        2532      2754      +222
- Partials      1432      1236      -196

Generated by Codecov Action

@sentrivana
sentrivana marked this pull request as ready for review September 11, 2026 14:55
@sentrivana
sentrivana merged commit d22d8a7 into major/3.0 Sep 14, 2026
149 checks passed
@sentrivana
sentrivana deleted the ivana/major/more-tests-ofc branch September 14, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants