Skip to content

chore: Adapt conversation_id tests #7465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sentrivana merged 1 commit into from
Sep 11, 2026
Merged

chore: Adapt conversation_id tests #7465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 6 additions & 202 deletions tests/tracing/test_conversation_id.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,7 @@
import pytest

import sentry_sdk
from sentry_sdk import start_span


def test_conversation_id_propagates_to_span_with_gen_ai_operation_name(
sentry_init, capture_events
):
"""Span with gen_ai.operation.name data should get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-op-name-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="http.client") as span:
span.set_data("gen_ai.operation.name", "chat")

(event,) = events
span_data = event["spans"][0]["data"]
assert span_data.get("gen_ai.conversation.id") == "conv-op-name-test"


def test_conversation_id_propagates_to_span_with_gen_ai_operation_name_span_streaming(
sentry_init, capture_items
):
"""Span with gen_ai.operation.name attribute should get conversation_id."""
Expand All @@ -49,26 +27,7 @@ def test_conversation_id_propagates_to_span_with_gen_ai_operation_name_span_stre
assert "gen_ai.conversation.id" not in segment["attributes"]


def test_conversation_id_propagates_to_span_with_ai_op(sentry_init, capture_events):
"""Span with ai.* op should get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-ai-op-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="ai.chat.completions"):
pass

(event,) = events
span_data = event["spans"][0]["data"]
assert span_data.get("gen_ai.conversation.id") == "conv-ai-op-test"


def test_conversation_id_propagates_to_span_with_ai_op_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_propagates_to_span_with_ai_op(sentry_init, capture_items):
"""Span with ai.* op should get conversation_id."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand All @@ -92,45 +51,7 @@ def test_conversation_id_propagates_to_span_with_ai_op_span_streaming(
assert "gen_ai.conversation.id" not in segment["attributes"]


@pytest.mark.parametrize("stream_gen_ai_spans", [True, False])
def test_conversation_id_propagates_to_span_with_gen_ai_op(
sentry_init, capture_events, capture_items, stream_gen_ai_spans
):
"""Span with gen_ai.* op should get conversation_id."""
sentry_init(
traces_sample_rate=1.0,
stream_gen_ai_spans=stream_gen_ai_spans,
)

if stream_gen_ai_spans:
items = capture_items("span")

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-gen-ai-op-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="gen_ai.invoke_agent"):
pass

spans = [item.payload for item in items]
span_data = spans[0]["attributes"]
else:
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-gen-ai-op-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="gen_ai.invoke_agent"):
pass

(event,) = events
span_data = event["spans"][0]["data"]

assert span_data.get("gen_ai.conversation.id") == "conv-gen-ai-op-test"


def test_conversation_id_propagates_to_span_with_gen_ai_op_span_streaming(
sentry_init,
capture_items,
):
Expand Down Expand Up @@ -159,26 +80,7 @@ def test_conversation_id_propagates_to_span_with_gen_ai_op_span_streaming(
assert "gen_ai.conversation.id" not in segment["attributes"]


def test_conversation_id_not_propagated_to_non_ai_span(sentry_init, capture_events):
"""Non-AI span should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-should-not-appear")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="http.client") as span:
span.set_data("some.other.data", "value")

(event,) = events
span_data = event["spans"][0]["data"]
assert "gen_ai.conversation.id" not in span_data


def test_conversation_id_not_propagated_to_non_ai_span_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_not_propagated_to_non_ai_span(sentry_init, capture_items):
"""Non-AI span should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand All @@ -202,27 +104,7 @@ def test_conversation_id_not_propagated_to_non_ai_span_span_streaming(
assert "gen_ai.conversation.id" not in segment["attributes"]


def test_conversation_id_not_propagated_when_not_set(sentry_init, capture_events):
"""AI span should not have conversation_id if not set on scope."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

# Ensure no conversation_id is set
scope = sentry_sdk.get_current_scope()
scope.remove_conversation_id()

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(op="ai.chat.completions"):
pass

(event,) = events
span_data = event["spans"][0]["data"]
assert "gen_ai.conversation.id" not in span_data


def test_conversation_id_not_propagated_when_not_set_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_not_propagated_when_not_set(sentry_init, capture_items):
"""AI span should not have conversation_id if not set on scope."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand All @@ -246,26 +128,7 @@ def test_conversation_id_not_propagated_when_not_set_span_streaming(
assert "gen_ai.conversation.id" not in segment["attributes"]


def test_conversation_id_not_propagated_to_span_without_op(sentry_init, capture_events):
"""Span without op and without gen_ai.operation.name should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-no-op-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(name="unnamed-span") as span:
span.set_data("regular.data", "value")

(event,) = events
span_data = event["spans"][0]["data"]
assert "gen_ai.conversation.id" not in span_data


def test_conversation_id_not_propagated_to_span_without_op_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_not_propagated_to_span_without_op(sentry_init, capture_items):
"""Span without op and without gen_ai.operation.name should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand All @@ -288,25 +151,6 @@ def test_conversation_id_not_propagated_to_span_without_op_span_streaming(


def test_conversation_id_propagates_with_gen_ai_operation_name_no_op(
sentry_init, capture_events
):
"""Span with gen_ai.operation.name but no op should still get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-no-op-but-data-test")

with sentry_sdk.start_transaction(name="test-tx"):
with start_span(name="unnamed-span") as span:
span.set_data("gen_ai.operation.name", "embedding")

(event,) = events
span_data = event["spans"][0]["data"]
assert span_data.get("gen_ai.conversation.id") == "conv-no-op-but-data-test"


def test_conversation_id_propagates_with_gen_ai_operation_name_no_op_span_streaming(
sentry_init, capture_items
):
"""Span with gen_ai.operation.name but no op should still get conversation_id."""
Expand All @@ -332,27 +176,7 @@ def test_conversation_id_propagates_with_gen_ai_operation_name_no_op_span_stream
assert "gen_ai.conversation.id" not in segment["attributes"]


def test_conversation_id_propagates_to_transaction_with_ai_op(
sentry_init, capture_events
):
"""Transaction with ai.* op should get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-tx-ai-op-test")

with sentry_sdk.start_transaction(op="ai.workflow", name="AI Workflow"):
pass

(event,) = events
trace_data = event["contexts"]["trace"]["data"]
assert trace_data.get("gen_ai.conversation.id") == "conv-tx-ai-op-test"


def test_conversation_id_propagates_to_segment_with_ai_op_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_propagates_to_segment_with_ai_op(sentry_init, capture_items):
"""Segment with ai.* op should get conversation_id."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand All @@ -371,27 +195,7 @@ def test_conversation_id_propagates_to_segment_with_ai_op_span_streaming(
assert segment["attributes"].get("gen_ai.conversation.id") == "conv-tx-ai-op-test"


def test_conversation_id_not_propagated_to_non_ai_transaction(
sentry_init, capture_events
):
"""Non-AI transaction should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0)
events = capture_events()

scope = sentry_sdk.get_current_scope()
scope.set_conversation_id("conv-tx-should-not-appear")

with sentry_sdk.start_transaction(op="http.server", name="HTTP Request"):
pass

(event,) = events
trace_data = event["contexts"]["trace"]["data"]
assert "gen_ai.conversation.id" not in trace_data


def test_conversation_id_not_propagated_to_non_ai_segment_span_streaming(
sentry_init, capture_items
):
def test_conversation_id_not_propagated_to_non_ai_segment(sentry_init, capture_items):
"""Non-AI segment should NOT get conversation_id."""
sentry_init(traces_sample_rate=1.0, trace_lifecycle="stream")
items = capture_items("span")
Expand Down
Loading