Repository navigation
fix(openai-agents): Stop setting response model based on the request model - #7413
alexander-alderman-webb wants to merge 2 commits into
Conversation
alexander-alderman-webb
changed the title
Codecov Results 📊✅ 130584 passed | ⏭️ 7122 skipped | Total: 137706 | Pass Rate: 94.83% | Execution Time: 460m 26s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2504 uncovered lines. Coverage diff@@ Coverage Diff @@
## master #PR +/-##
==========================================
+ Coverage 90.25% 90.26% +0.01%
==========================================
Files 193 193 —
Lines 25725 25720 -5
Branches 9494 9490 -4
==========================================
+ Hits 23217 23216 -1
- Misses 2508 2504 -4
- Partials 1432 1432 —Generated by Codecov Action |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5bb18fd. Configure here.
| if agent.model: | ||
| model_name = agent.model.model if hasattr(agent.model, "model") else agent.model | ||
| elif hasattr(agent, "_sentry_request_model"): | ||
| model_name = agent._sentry_request_model |
There was a problem hiding this comment.
Request model lost for default models
Medium Severity
Removing _sentry_request_model drops the resolved request model when agent.model is unset. Agents that use the SDK default or a RunConfig model no longer get gen_ai.request.model, and chat spans are named chat None.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 5bb18fd. Configure here.
|
Nevermind I've mixed stuff up |
Description
The response model doesn't necessarily equal the request model.
Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)