Repository navigation
feat(unwinder): unwind remote threads with libunwindstack - #2267
Merged
jpnurmi merged 1 commit intoOct 29, 2026
Merged
Conversation
The crash daemon could only unwind the threads that did not crash with `libunwind_remote`, which Android builds lack because they use libunwindstack. Add a `libunwindstack_remote` backend, compiled in only with the native backend, that attaches to a thread with ptrace, reads its registers with `Regs::RemoteGet()`, and unwinds it. Share the ptrace attach loop with `libunwind_remote`. This prepares the native backend for Android.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## jpnurmi/feat/native-elf-offsets #2267 +/- ##
===================================================================
+ Coverage 75.92% 76.09% +0.17%
===================================================================
Files 104 104
Lines 29863 29870 +7
Branches 5541 5542 +1
===================================================================
+ Hits 22672 22729 +57
+ Misses 5806 5751 -55
- Partials 1385 1390 +5 🚀 New features to boost your workflow:
|
mujacica
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash daemon could only unwind the threads that did not crash with
libunwind_remote, which Android builds lack because they use libunwindstack. Add alibunwindstack_remotebackend, compiled in only with the native backend, that attaches to a thread with ptrace, reads its registers withRegs::RemoteGet(), and unwinds it. Share the ptrace attach loop withlibunwind_remote.This prepares the remote unwinding for the native backend on Android.
#skip-changelog (extracted from #1725)