Skip to content

fix(modulefinder): handle ENOSYS in read_safely for Kubernetes seccomp #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HrMathematiker wants to merge 1 commit into from
Closed

fix(modulefinder): handle ENOSYS in read_safely for Kubernetes seccomp #1654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/modulefinder/sentry_modulefinder_linux.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,13 @@ read_safely(void *dst, void *src, size_t size)
// See https://github.com/getsentry/sentry-native/issues/578).
// Also, the syscall is only available in Linux 3.2, meaning Android 17.
// In that case we get an `EINVAL`.
// Additionally, Kubernetes default seccomp profiles (RuntimeDefault) block
// `process_vm_readv` and return `ENOSYS`, causing all ELF module
// validations to fail and `debug_meta.images` to be absent from
// manually-captured events.
//
// In either of these cases, just fall back to an unsafe `memcpy`.
if (!rv && (errno == EPERM || errno == EINVAL)) {
// In any of these cases, just fall back to an unsafe `memcpy`.
if (!rv && (errno == EPERM || errno == EINVAL || errno == ENOSYS)) {
memcpy(dst, src, size);
rv = true;
}
Expand Down
Loading