Repository navigation

feat(transport): add HTTP retry with exponential backoff - #1520

Merged

jpnurmi merged 120 commits into

masterfrom

jpnurmi/feat/http-retry

Mar 31, 2026

Merged

feat(transport): add HTTP retry with exponential backoff#1520
jpnurmi merged 120 commits into
masterfrom
jpnurmi/feat/http-retry

Commits on Mar 17, 2026
- feat(transport): add HTTP retry logic with exponential backoff
  
  jpnurmi
  and
  claude
  committed
  663f3bb
- fix(retry): filter startup scan by timestamp, create cache dir
  
  jpnurmi
  and
  claude
  committed
  52a273e
- fix(retry): use wall clock time instead of monotonic time
  
  jpnurmi
  and
  claude
  committed
  e230f8b
- ref(retry): define backoff base in seconds
  
  jpnurmi
  and
  claude
  committed
  3810f2b
- ref(retry): replace scan+free_paths with foreach callback API
  
  jpnurmi
  and
  claude
  committed
  a910f32
- feat(transport): set 15s request timeout for curl and winhttp
  
  jpnurmi
  and
  claude
  committed
  8b8921b
- fix(retry): avoid duplicate delayed retry tasks on startup
  
  jpnurmi
  and
  claude
  committed
  46d2a9e
- ref(retry): take options in sentry__retry_new, own path construction
  
  jpnurmi
  and
  claude
  committed
  4f3d625
- ref(retry): set startup_time at creation, remove setter
  
  jpnurmi
  and
  claude
  committed
  199bd30
- fix(retry): return total file count so polling continues during backoff
  
  jpnurmi
  and
  claude
  committed
  94a7ca7
- fix(retry): use callback return value to track remaining retry files
  
  jpnurmi
  and
  claude
  committed
  011fbb5
- ref(retry): rename constants to SENTRY_RETRY_INTERVAL and SENTRY_RETRY_THROTTLE
  
  jpnurmi
  and
  claude
  committed
  f673193
- ref(retry): encapsulate retry scheduling into the retry module
  
  jpnurmi
  and
  claude
  committed
  caef6c1
- ref(transport): remove unnecessary includes, restore blank line
  
  jpnurmi
  and
  claude
  committed
  9c7c99d
- ref(retry): move precondition checks to callers
  
  jpnurmi
  and
  claude
  committed
  3813feb
- ref(transport): extract http_send_envelope helper
  
  jpnurmi
  and
  claude
  committed
  ea5233f
- test(retry): remove redundant retry_no_duplicate_rescan test
  
  jpnurmi
  and
  claude
  committed
  f17f8f9
- ref(curl): use CURLOPT_TIMEOUT_MS for consistency with winhttp and crashpad
  
  jpnurmi
  and
  claude
  committed
  e7886a4
- ref(retry): unify startup and poll into a single task
  
  jpnurmi
  and
  claude
  committed
  ce4ac80
- ref(retry): extract sentry__retry_make_path helper
  
  jpnurmi
  and
  claude
  committed
  34d5131
- fix(retry): prevent envelope duplication between retry and cache
  
  jpnurmi
  and
  claude
  committed
  8015d2c
- ref(database): derive can_cache flag to skip cache dir creation early
  
  jpnurmi
  and
  claude
  committed
  8fcdb4f
- ref(retry): change send callback to envelope-based API
  
  jpnurmi
  and
  claude
  committed
  551ad74
- test(retry): verify cache_keep preserves envelopes on successful send
  
  jpnurmi
  and
  claude
  committed
  d2f1a07
- fix(retry): use PRIu64 format specifier for uint64_t
  
  jpnurmi
  and
  claude
  committed
  3750856
- fix(retry): guard against unsigned underflow in backoff check
  
  jpnurmi
  and
  claude
  committed
  0cbf407
- fix(retry): prevent startup poll from re-processing same-session envelopes
  
  jpnurmi
  and
  claude
  committed
  3b2a5d6
- fix(retry): flush pending retries on shutdown
  
  jpnurmi
  and
  claude
  committed
  6608084
- ref(retry): use millisecond timestamps for retry filenames
  
  jpnurmi
  and
  claude
  committed
  961ec95
- fix(retry): flush pending retries synchronously before shutdown
  
  jpnurmi
  and
  claude
  committed
  558c32e
- fix(retry): stop retrying on network failure
  
  jpnurmi
  and
  claude
  committed
  be1d7cf
- fix(retry): dump unsent envelopes to retry dir on shutdown timeout
  
  jpnurmi
  and
  claude
  committed
  fccc565
- test(retry): update expectations for stop-on-failure behavior
  
  jpnurmi
  and
  claude
  committed
  d831987
- style(retry): fix line length in unit tests
  
  jpnurmi
  and
  claude
  committed
  69f4f68
- fix(retry): prevent duplicate envelope writes from detached worker
  
  jpnurmi
  and
  claude
  committed
  5562feb
- docs: add changelog entry for HTTP retry feature
  
  jpnurmi
  and
  claude
  committed
  0664fb3
- test(retry): use sentry__retry_send instead of duplicated eligibility logic
  
  jpnurmi
  and
  claude
  committed
  c241adf
- fix(retry): raise backoff cap from 2h to 8h to match crashpad
  
  jpnurmi
  and
  claude
  committed
  a053ccb
- refactor(retry): introduce retry_item_t to avoid re-parsing filenames
  
  jpnurmi
  and
  claude
  committed
  71ee17a
- feat(retry): add debug and warning output for HTTP retries
  
  jpnurmi
  and
  claude
  committed
  dfe7c1f
- refactor(cache): add cache_path to sentry_run_t and centralize cache writes
  
  jpnurmi
  and
  claude
  committed
  5d80da6
- fix(transport): use connect-only timeouts for curl and winhttp
  
  jpnurmi
  and
  claude
  committed
  06cca66
- fix(retry): decrement total count when removing corrupt envelope files
  
  jpnurmi
  and
  claude
  committed
  fd6c577
- fix(retry): only warn about exhausted retries on network failure
  
  jpnurmi
  and
  claude
  committed
  173de80
- docs(retry): add doc comments to sentry_retry.h declarations
  
  jpnurmi
  and
  claude
  committed
  0482bf4
- feat(transport): add sentry_transport_retry()
  
  jpnurmi
  and
  claude
  committed
  39f36ec
- refactor(retry): store retry envelopes in cache/ directory
  
  jpnurmi
  and
  claude
  committed
  7b30688
- fix(retry): own cache_path to prevent use-after-free on detached thread
  
  jpnurmi
  and
  claude
  committed
  e6c8db4
- fix(retry): don't consume shutdown timeout with bgworker flush
  
  jpnurmi
  and
  claude
  committed
  c520575
- fix(retry): flush in-flight retries before shutdown
  
  jpnurmi
  and
  claude
  committed
  79d1732
- refactor(retry): replace http_retries count with boolean http_retry
  
  jpnurmi
  and
  claude
  committed
  344dcc8
- fix(transport): use explicit WinHTTP send/receive timeouts
  
  jpnurmi
  and
  claude
  committed
  5cdcc47
- fix(retry): deduplicate poll tasks on concurrent envelope failures
  
  jpnurmi
  and
  claude
  committed
  9136500
- fix(retry): set sealed flag before dumping queued envelopes
  
  jpnurmi
  and
  claude
  committed
  9b14dc2
- fix(retry): prevent retry flush from consuming shutdown timeout
  
  jpnurmi
  and
  claude
  committed
  e75f595
- fix(retry): zero-initialize retry struct after malloc
  
  jpnurmi
  and
  claude
  committed
  136fabf
- fix(retry): skip flush task after seal to prevent duplicate sends
  
  jpnurmi
  and
  claude
  committed
  1a0d99b
- refactor(database): remove unused sentry__run_write_cache
  
  jpnurmi
  and
  claude
  committed
  ed28b85
- fix(retry): make trigger one-shot to prevent rapid retry exhaustion
  
  jpnurmi
  and
  claude
  committed
  62999c3
- fix(core): check http_retry option instead of transport capability
  
  jpnurmi
  and
  claude
  committed
  70b1040
- fix(retry): prevent UB from negative count in backoff shift
  
  jpnurmi
  and
  claude
  committed
  794df4b
- fix(options): normalize http_retry with !! to match other boolean setters
  
  jpnurmi
  and
  claude
  committed
  83475e4
- revert(database): restore original variable names and whitespace in write_envelope
  
  jpnurmi
  and
  claude
  committed
  8aae746
- docs: clarify sentry_transport_retry behavior and limitations
  jpnurmi
  committed
  791d598
- docs(retry): document retry behavior for network failures vs HTTP responses
  jpnurmi
  committed
  a2efe25
- fix(retry): only clear startup_time when envelope is written
  jpnurmi
  committed
  4b1e7d7
- fix(retry): check for NULL from sentry__path_clone
  jpnurmi
  committed
  6064f1d
- fix(retry): apply backoff when system clock moves backward
  jpnurmi
  committed
  45ee886
- fix(retry): increase SENTRY_RETRY_ATTEMPTS to 6 to match Crashpad
  
  jpnurmi
  and
  claude
  committed
  ec59d5e
- fix(retry): avoid retry flush consuming entire shutdown timeout
  
  jpnurmi
  and
  claude
  committed
  00bef01
- fix(retry): warn on failed retry envelope rename
  
  jpnurmi
  and
  claude
  committed
  d96beb1
- fix(retry): check for NULL from sentry__path_clone in retry send
  
  jpnurmi
  and
  claude
  committed
  985b3da
- fix(retry): fix data race on startup_time between threads
  
  jpnurmi
  and
  claude
  committed
  87532a3
- fix(retry): clear retry_func when retry fails to initialize
  
  jpnurmi
  and
  claude
  committed
  754a65d
- fix(retry): persist non-event envelopes to the retry cache
  
  jpnurmi
  and
  claude
  committed
  0e64115
- fix(retry): close race between poll task and enqueue on scheduled flag
  
  jpnurmi
  and
  claude
  committed
  9ab3e11
- refactor(database): add retry_count to write_envelope, add sentry__run_write_cache
  
  jpnurmi
  and
  claude
  committed
  5a10044
- refactor(database): make sentry_run_t refcounted
  
  jpnurmi
  and
  claude
  committed
  f35817d
- refactor(cache): strip retry prefix in move_cache and simplify handle_result
  
  jpnurmi
  and
  claude
  committed
  123a7be
- fix(cache): use cache_name instead of src_name for UUID in move_cache
  
  jpnurmi
  and
  claude
  committed
  acfd148
- fix(retry): prevent duplicate cache writes during shutdown race
  
  jpnurmi
  and
  claude
  committed
  019e0e9
- fix(cache): replace length heuristic with proper filename parsing in move_cache
  
  jpnurmi
  and
  claude
  committed
  0e83c47
- docs: fix retry count 5 → 6 in sentry_transport_retry docs
  
  jpnurmi
  and
  claude
  committed
  5f8e452
- fix(retry): prevent poll task from re-arming after shutdown
  
  jpnurmi
  and
  claude
  committed
  69ffc09
- fix(winhttp): cancel in-flight request before shutdown to unblock worker
  
  jpnurmi
  and
  claude
  committed
  e50dcf5
- fix(winhttp): fix double-close race on client->request between cancel and worker
  
  jpnurmi
  and
  claude
  committed
  db19679
- fix(winhttp): use on_timeout callback to unblock worker instead of cancel
  
  jpnurmi
  and
  claude
  committed
  898308d
- fix(winhttp): remove unnecessary local request snapshot in winhttp_send_task
  
  jpnurmi
  and
  claude
  committed
  7db3274
- fix(sync): don't force running=0 before on_timeout callback
  
  jpnurmi
  and
  claude
  committed
  5b32779
- fix(test): disable transport retry in unit tests to fix valgrind flakiness
  
  jpnurmi
  and
  claude
  committed
  9c8d803
- fix(retry): clear sealed_envelope after match to prevent address-reuse data loss
  
  jpnurmi
  and
  claude
  committed
  a91842a
- ref: consolidate filename formatting into make_cache_path
  
  jpnurmi
  and
  claude
  committed
  c17329a
- Adapt to sentry__session_new() change
  jpnurmi
  committed
  3461f52
- ref: cache envelopes only on failed HTTP send
  
  jpnurmi
  and
  claude
  committed
  36568c1
- Clarify bgworker shutdown timeout comment
  
  jpnurmi
  and
  claude
  committed
  1d85dd8
- Cache envelopes only on failed HTTP send
  
  jpnurmi
  and
  claude
  committed
  168a807
- Remove unused sentry__transport_can_retry
  
  jpnurmi
  and
  claude
  committed
  c0f920d
- fix: incref options in cleanup task to prevent use-after-free
  
  jpnurmi
  and
  claude
  committed
  bb06d6f
- Update sentry docs URL for network failure handling
  jpnurmi
  committed
  8840444
- Replace pointer comparison with envelope tag in retry seal check
  
  jpnurmi
  and
  claude
  committed
  93d884a
- Add TODO for retry jitter and shorter poll interval
  jpnurmi
  committed
  93db900
- Initialize tag for raw envelopes loaded from disk
  
  cursoragent
  authored and
  jpnurmi
  committed
  8f104d2
Commits on Mar 18, 2026
- Implement on_timeout for curl transport
  
  jpnurmi
  and
  claude
  committed
  878ace5
Commits on Mar 30, 2026
- Merge upstream/master into http-retry branch
  
  jpnurmi
  and
  claude
  committed
  003e9f3
- Make http_retry off by default
  
  jpnurmi
  and
  claude
  committed
  381b476
- Remove dead envelope tag mechanism
  
  jpnurmi
  and
  claude
  committed
  a485974
- Remove dead retry_func fallback branch
  
  jpnurmi
  and
  claude
  committed
  9672e6e
- Fix handle_result caching successfully delivered envelopes
  
  jpnurmi
  and
  claude
  committed
  e914431
- Clean up unnecessary env variables in integration tests
  
  jpnurmi
  and
  claude
  committed
  2c12e50
- Fix dump_queue writing retry envelopes to run dir instead of cache
  
  jpnurmi
  and
  claude
  committed
  c483e42
- Fix multiple-envelope tests failing on Windows
  
  jpnurmi
  and
  claude
  committed
  323cc5e
- Drop retry-count assertions from multiple_network_error test
  
  jpnurmi
  and
  claude
  committed
  a38f78b
- Remove premature STARTUP→RUNNING transition from retry_enqueue
  
  jpnurmi
  and
  claude
  committed
  5d4dbff
- Drop flaky retry-count assertions from multiple_network_error test
  
  jpnurmi
  and
  claude
  committed
  556ecc7
- Make retry_flush_task unconditional
  
  jpnurmi
  and
  claude
  committed
  5599fb9
- Fix retry_flush_task re-processing same-session envelopes
  
  jpnurmi
  and
  claude
  committed
  8447dc9
- Remove retry_send_cb wrapper
  
  jpnurmi
  and
  claude
  committed
  382084d
- Remove retry filename formatting from write_envelope
  
  jpnurmi
  and
  claude
  committed
  899b385
- Remove stale sentry_sync.h include from sentry_envelope.c
  
  jpnurmi
  and
  claude
  committed
  8371796
Commits on Mar 31, 2026
- Merge remote-tracking branch 'upstream/master' into jpnurmi/feat/http-retry
  jpnurmi
  committed
  14a0aef

Commits

Commits on Mar 17, 2026

Commits on Mar 18, 2026

Commits on Mar 30, 2026

Commits on Mar 31, 2026