Skip to content

Sending captured events should honor sending fail. #932

Closed

Description

@stima

Description

Sending captured events should honor sending fail.

When does the problem happen

  • During build
  • During run-time
  • When capturing a hard crash

Environment

  • OS: Unrelated
  • Compiler: Unrelated
  • CMake version and config: Unrelated

Steps To Reproduce

  1. Generate crash under Sentry SDK. That should trigger unsent event inside sentry database folder
  2. Turn off networking
  3. Run Sentry SDK again.

Expected: The event is not send and event metadata is not removed, appropriate log statement raised.
Actual: Event is not send, event metadata is removed.

Log output

Activity

  1. moved this to Waiting for: Product Owner in GitHub Issues with 👀 2on Jan 3, 2024
  2. supervacuus commented on Jan 8, 2024

    @supervacuus
    Collaborator

    There is currently no transport transactionality of events. If an event ends up in the send queue and the transport cannot send for whatever reason, the event is lost. If your use case expects regular network unavailability and requires delivery guarantees, the transport implementation can be customized.

    Send errors should be visible in the logs.

  3. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 2on Jan 8, 2024
  4. stima commented on Jan 8, 2024

    @stima
    ContributorAuthor

    Thanks I would consider to look to custom transport impelementation.

  5. moved this to Waiting for: Product Owner in GitHub Issues with 👀 2on Jan 8, 2024
  6. supervacuus commented on Jan 10, 2024

    @supervacuus
    Collaborator

    Btw since you use crashpad, implementing a custom transport will not help you with adding delivery guarantees for crashes since the crashpad_handler uses its own transport.

  7. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 2on Jan 10, 2024
  8. 7 remaining items

  9. added
    Errorsissues relates to the error reporting product
    and removed on Mar 26, 2026
  10. jpnurmi commented on May 8, 2026

    @jpnurmi
    Collaborator

    I believe this has been addressed by the recent HTTP retry and offline-caching -related work:

    Please let me know if anything is missing. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Errorsissues relates to the error reporting productFeaturenew featureNativeplatform label

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions