Repository navigation
ci(release): Bump craft to 3.9.0 and update config - #298
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
sentry-junior
Bot
requested review from
markushi and
runningcode
and removed request for
a team
November 3, 2026 21:02
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the release workflow's pinned
getsentry/craftaction from 2.19.0 (c6e2f049, labeled# v2) to 3.9.0 (2e29b081).Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could open a getsentry/publish issue even with a
release-blockerissue open (seen in getsentry/symbolic run 41665569364). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors. Older pins don't get the fix.Compatibility with craft 3.x:
.craft.ymldoesn't setchangelog.includePathsorunownedPaths.minVersionis 0.29.3 (below 2.21.0), so automatic version bumping isn't used and craft runsscripts/bump-version.shas before.with:inputs stay valid.prepare 99.0.0 --dry-run --no-pushagainst currentmain. It ranscripts/bump-version.shand finished without errors. It warns thatchangelogPolicyis deprecated in favor ofchangelog.policy; that's not an error.There are no open
release-blockerissues in this repo right now, so releases aren't affected today.Config changes (
.craft.yml, for craft 3.9.0):minVersion: 0.29.3→3.9.0.minVersionwas 0.29.3, below 2.21.0, and there was nopreReleaseCommand, so craft ranscripts/bump-version.shby default. From 2.21.0 on, craft uses automatic target bumping when no command is set, so I addedpreReleaseCommand: bash scripts/bump-version.shto keep the script running.minVersionwas below 2.14.0, so the versioning policy defaulted tomanual. From 2.14.0 on, the default isauto, so I addedversioning.policy: manualto keep that behavior. (Explicitautoor bump keywords likeminornow work as a version input, because craft checks those againstminVersionand not the policy.)changelogPolicy: autowithchangelog.policy: auto.prepare 99.0.0 --dry-run --no-push, before and after: both runs bump the same files (CHANGELOG.md,pom.xml) and finish without errors, and thechangelogPolicydeprecation warning is gone.via @BYK.
--
View Session in Sentry