Skip to content

ci(release): Bump craft to 3.9.0 and update config - #298

Open
sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0
Open

sentry-junior[bot] wants to merge 2 commits into
mainfrom
ci/bump-craft-3.9.0

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

This bumps the release workflow's pinned getsentry/craft action from 2.19.0 (c6e2f049, labeled # v2) to 3.9.0 (2e29b081).

Why: craft's "Check release blockers" step used to ask GitHub to cancel the run and then exit 0, so the action kept going and could open a getsentry/publish issue even with a release-blocker issue open (seen in getsentry/symbolic run 41665569364). getsentry/craft#956 fixed this in 3.9.0: the step now fails right away, and also fails if the blocker lookup errors. Older pins don't get the fix.

Compatibility with craft 3.x:

  • None of the 3.0 breaking changes apply:
    • .craft.yml doesn't set changelog.includePaths or unownedPaths.
    • minVersion is 0.29.3 (below 2.21.0), so automatic version bumping isn't used and craft runs scripts/bump-version.sh as before.
    • There's no nuget target.
  • Action inputs only gained new optional ones between 2.x and 3.9.0, so the existing with: inputs stay valid.
  • I ran craft 3.9.0 prepare 99.0.0 --dry-run --no-push against current main. It ran scripts/bump-version.sh and finished without errors. It warns that changelogPolicy is deprecated in favor of changelog.policy; that's not an error.

There are no open release-blocker issues in this repo right now, so releases aren't affected today.

Config changes (.craft.yml, for craft 3.9.0):

  • minVersion: 0.29.3 → 3.9.0.
  • minVersion was 0.29.3, below 2.21.0, and there was no preReleaseCommand, so craft ran scripts/bump-version.sh by default. From 2.21.0 on, craft uses automatic target bumping when no command is set, so I added preReleaseCommand: bash scripts/bump-version.sh to keep the script running.
  • minVersion was below 2.14.0, so the versioning policy defaulted to manual. From 2.14.0 on, the default is auto, so I added versioning.policy: manual to keep that behavior. (Explicit auto or bump keywords like minor now work as a version input, because craft checks those against minVersion and not the policy.)
  • Replaced the deprecated changelogPolicy: auto with changelog.policy: auto.
  • craft 3.9.0 prepare 99.0.0 --dry-run --no-push, before and after: both runs bump the same files (CHANGELOG.md, pom.xml) and finish without errors, and the changelogPolicy deprecation warning is gone.

via @BYK.

--

View Session in Sentry

Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior
sentry-junior Bot requested review from a team and adinauer as code owners November 3, 2026 21:02
@sentry-junior
sentry-junior Bot requested review from markushi and runningcode and removed request for a team November 3, 2026 21:02
Co-Authored-By: BYK <126780+BYK@users.noreply.github.com>
@sentry-junior sentry-junior Bot changed the title ci(release): Bump getsentry/craft to 3.9.0 ci(release): Bump craft to 3.9.0 and update config Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant