Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 6bb269d (PR test merge using develop at 86c5981) Against: 86c5981 (develop) · base run #65750 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 6 successful. See the run. Successful checks
|
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b7f3888. Configure here.
h3 v1 (1.8+) and h3 v2 both have event.headers with the request's web Headers. Read the x-nitro-prerender header from it, in place of the cast to a per-version event shape. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Visitors of a Nuxt page cached by a route rule (
cache,swr,isron Vercel/Netlify) continued the server trace of the request that rendered it. Like Next.js (#25318) and SvelteKit (#26301), these pages now get asentry-cache-originmeta tag in place of the trace tags. The pageload isstaticand links the render if it was sampled.isronly counts as cached on presets with a platform cache: onnode-server, Nitro rendersisrpages per request. Tested on a Vercel deploy.How to review: Start with
runtime/utils/pageMetaTags.ts(server decision) andruntime/utils/cacheOriginPageload.ts(pageload).Unsure about:
withCacheOriginnow exists in Next.js, SvelteKit and Nuxt. I plan to share it from@sentry/browserin a follow-up.Example with the UI changes from getsentry/sentry#130771
https://sentry-4x3dkn58u.sentry.dev/explore/traces/trace/e7492219ab72481989d6a2cd670fe8d9/
Linear: JSSDK-36