Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 6352e60 (PR test merge using develop at 2c3a3b2) Against: b722d3c (develop) · base run #64026
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 67 successful. See the run.
Successful checks
|
JPeer264
force-pushed
the
jp/cloudflare-without-tracing-e2e
branch
4 times, most recently
from
October 25, 2026 11:39
d17e4c0 to
56b314e
Compare
The SDK now reads `ctx.tracing.getActiveSpan().spanContext()` and sets
the propagation context to the Cloudflare trace id and span id. Errors,
logs and spans then use the same trace id as the spans that Cloudflare
exports, also when `tracesSampleRate` is 0. An incoming `sentry-trace`
header keeps precedence. Runtimes without `spanContext()` and invocations
that Cloudflare does not trace keep the current behavior.
`spanContext()` ships in workerd 1.20261009.1, so only the optional CI
job with the latest wrangler runs the new code path. The integration
tests select the expected values of each runtime with
`supports({ minWorkerd })`. The latest wrangler traces every local
invocation, so a root span can have the Cloudflare span as parent, and
the tests find the child segment by its parent instead.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cloudflare-without-tracing-e2e
branch
from
October 27, 2026 15:52
56b314e to
a338f2a
Compare
JPeer264
force-pushed
the
jp/cloudflare-without-tracing-e2e
branch
from
October 27, 2026 16:35
a338f2a to
18e73f2
Compare
…acing The new `cloudflare-workers-without-tracing-send-to-sentry` app deploys a real Worker with `tracesSampleRate: 0` and Cloudflare traces on. Its test checks that an error in Sentry has the trace id of the Cloudflare trace and the Cloudflare request span as its parent. The test finds the Cloudflare request span in Workers Logs by the `cf-ray` of the request, with the new `fetchWorkersLogsEvents` helper. The query endpoint needs a `CLOUDFLARE_API_TOKEN` with "Workers Observability: Edit". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cloudflare-without-tracing-e2e
branch
from
October 28, 2026 23:25
18e73f2 to
2968e79
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2968e79. Configure here.
JPeer264
marked this pull request as ready for review
November 9, 2026 12:03
JPeer264
requested review from
Lms24,
andreiborza,
chargome,
isaacs and
msonnb
and removed request for
a team
November 9, 2026 12:03
JPeer264
requested review from
nicohrubec
and removed request for
Lms24,
chargome,
isaacs and
msonnb
November 9, 2026 12:03
nicohrubec
reviewed
Nov 12, 2026
nicohrubec
left a comment
nicohrubec
left a comment
Member
There was a problem hiding this comment.
does it provide any benefit for us to actually send this to sentry instead of just checking the data that leaves the sdk as we do with other e2e tests? this introduces risk of flakiness and we also moved away from this again for the ai tests
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the e2e app
cloudflare-workers-without-tracing-send-to-sentry. It deploys a real Worker withtracesSampleRate: 0and Cloudflare traces on, and checks that an error in Sentry has the Cloudflare trace id and the Cloudflare request span as its parent. More tests without tracing can go into this app.Why
The integration tests of #25613 run on a local workerd. This test checks the fix on Cloudflare, against the span that Workers Observability stores for the request.
Sentry traces
With #25613, the error is in the Cloudflare trace: https://sentry-sdks.sentry.io/explore/traces/trace/666e09b1979b18724b8fd77faed99e1b/?project=4510555608449024&statsPeriod=14d
Without #25613, the error has its own trace: https://sentry-sdks.sentry.io/explore/traces/trace/bc56b593dcf941c7b21af6216f215dff/?project=4510555608449024&statsPeriod=14d