Conversation
Contributor
size-limit report 📦
|
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7780fe0. Configure here.
An unsampled standalone span (e.g. a late INP span) recorded a `transaction` outcome when it started, although it never becomes a transaction, and a second `span` outcome when it ended. Record a single `span` outcome on start instead. Derive the expected span count in the static sampling integration test from the `GET /ok` transaction, so it also holds on Bun, which creates no Express spans. Co-Authored-By: Claude <noreply@anthropic.com>
Run event processors, `ignoreSpans`, `beforeSendSpan` and `beforeSendTransaction` on the same transaction and check that every span is either sent or counted exactly once, both when the transaction is sent and when `beforeSendTransaction` drops it. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client report spec calls for recording category
spanclient outcomes, also if streaming is disabled. This PR makes the change to record outcomes for each span, including one for the transaction itself when a transaction is sampled negatively, as well as when it's dropped.The transaction/event processing pipeline had a bunch of holes though for span counts, since any combination of
ignoreSpans, event processors andbeforeSendSpancould drop child spans in any of those callbacks. So for example, a transaction that originally had 10 child spans and dropsnow all together reports 11
spans and 1transactionoutcome, with the correct reasons. No span drops are double-counted.