[Gitflow] Merge master into develop - #24991
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meta(changelog): Update changelog for 11.3.0
javascript-sdk-gitflow
Bot
requested review from
Lms24,
andreiborza,
chargome,
isaacs,
logaretm and
nicohrubec
and removed request for
a team
October 2, 2026 13:02
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "@sentry/core": "11.3.0", | ||
| "@sentry/node": "11.3.0", | ||
| "@sentry/react": "11.3.0", | ||
| "@sentry/server-runtime-injection": "11.3.0", |
Contributor
There was a problem hiding this comment.
Bug: The sourcemap upload script can silently succeed without uploading anything if no assets are emitted, misleading the user.
Severity: MEDIUM
Suggested Fix
Add a validation check before the upload step. If emitted.length is 0, either fail the script with an error message or skip the upload and log a warning indicating that no assets were found to upload.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/remix/package.json#L85
Potential issue: The sourcemap upload script can silently succeed without uploading any
files. If the `emitAssets` function returns an empty array (i.e., `emitted.length ===
0`), the script proceeds to the upload step. It then calls `sentry.sourcemap.upload`
with an empty `ext` parameter, which does nothing, but the script still logs a success
message like `[sentry] uploaded release X`. This misleads the user into believing
sourcemaps were successfully uploaded when none were. This can occur if an entry file is
misconfigured or if there's a compilation error.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge master branch into develop