feat(remix): Capture Remix 3 component render errors - #24873
Merged
chargome merged 1 commit intoOct 1, 2026
Merged
Conversation
Member
Author
|
bugbot run |
chargome
added this pull request to stack #24875
September 30, 2026 09:46
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9b3ebde. Configure here.
Contributor
size-limit report 📦
|
chargome
removed this pull request from stack #24875
September 30, 2026 11:41
chargome
added this pull request to stack #24884
September 30, 2026 11:41
chargome
marked this pull request as ready for review
September 30, 2026 13:14
chargome
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 30, 2026 13:14
chargome
force-pushed
the
charlygomez/js-3768-remix-3-client-error-capture
branch
from
September 30, 2026 13:41
9b3ebde to
f33fbed
Compare
chargome
force-pushed
the
charlygomez/js-3768-remix-3-client-error-capture
branch
2 times, most recently
from
September 30, 2026 14:23
1012e6a to
be85720
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+71
to
+74
| function readComponentError(event: Event): unknown { | ||
| const error = (event as ErrorEvent).error; | ||
| return error !== undefined ? error : event; | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: The null check in readComponentError is incorrect for cross-origin errors, where error can be null. This causes loss of error context when reporting.
Severity: MEDIUM
Suggested Fix
Update the condition in readComponentError to handle both null and undefined values for the error property. Changing the check from error !== undefined to error != null will ensure that the function correctly falls back to returning the event object itself in cases of cross-origin errors.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/remix/src/v3/client/errors.ts#L71-L74
Potential issue: The `readComponentError` function checks for an error object on an
event using `error !== undefined`. For cross-origin script errors, browsers often set
the `error` property to `null`. The current check incorrectly passes this `null` value
to `captureException`, which then creates a generic error report with the message
"null". This results in the loss of valuable context from the original event object,
hindering debugging efforts for cross-origin errors.
Did we get this right? 👍 / 👎 to inform future reviews.
chargome
force-pushed
the
charlygomez/js-3768-remix-3-client-error-capture
branch
2 times, most recently
from
September 30, 2026 15:01
ee57253 to
c9a8569
Compare
chargome
force-pushed
the
charlygomez/js-3768-remix-3-client-error-capture
branch
from
October 1, 2026 08:12
c9a8569 to
cd5e136
Compare
s1gr1d
approved these changes
Oct 1, 2026
| return channel; | ||
| } | ||
|
|
||
| export default { tracingChannel }; |
Member
Author
There was a problem hiding this comment.
We do both, no specific reason here
Base automatically changed from
charlygomez/js-3768-add-remix-3-browser-sdk-with-a-bundled-client-entry
to
develop
October 1, 2026 13:33
The `remix/ui` runtime sends every render, scheduler, frame and hydration error to the event target `run()` returns, and dispatching an event does not rethrow. So `window.onerror` and `unhandledrejection` never see them, and the default browser integrations report nothing from the component layer. Removing the listener added here makes the new e2e test fail, which is the cheapest proof of that. The `diagnostics_channel` browser shim ships as its own file because the browser transform imports it by URL, so an inlined copy would leave the page with two subscriber registries. Its subscription is dormant until that transform lands. Costs 0.27 KB gzipped in the client bundle, which stays inside the existing budget. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3768-remix-3-client-error-capture
branch
from
October 1, 2026 13:33
cd5e136 to
e6c1bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
remix/uiruntime sends every render, scheduler, frame and hydration error to the event targetrun()returns, and dispatching an event does not rethrow. Sowindow.onerrorandunhandledrejectionnever see them, and the default browser integrations report nothing from the component layer. Removing the listener added here makes the new e2e test fail.Costs 0.27 KB gzipped in the client bundle, inside the existing budget.
Fixes #24665