feat(remix): Inject debug IDs through the Remix 3 asset server - #24761
Open
chargome wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
September 30, 2026 09:52
f24aa9d to
652eba6
Compare
chargome
changed the base branch from
develop
to
charlygomez/js-3768-remix-3-client-error-capture
September 30, 2026 09:52
Member
Author
|
bugbot run |
chargome
added this pull request to stack #24875
September 30, 2026 09:53
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
September 30, 2026 10:02
652eba6 to
617f5b4
Compare
chargome
removed this pull request from stack #24875
September 30, 2026 11:41
chargome
added this pull request to stack #24884
September 30, 2026 11:41
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
September 30, 2026 13:41
617f5b4 to
22bb2d8
Compare
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
2 times, most recently
from
September 30, 2026 14:23
5ddd4a6 to
0b89ad2
Compare
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
September 30, 2026 14:43
0b89ad2 to
54eb070
Compare
Member
Author
|
bugbot run |
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
September 30, 2026 15:01
54eb070 to
3ffe768
Compare
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3ffe768. Configure here.
chargome
requested review from
isaacs,
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
September 30, 2026 15:24
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
October 1, 2026 08:12
3ffe768 to
78f8a55
Compare
s1gr1d
approved these changes
Oct 1, 2026
Comment on lines
+9
to
13
| scripts: { | ||
| define: { 'process.env.E2E_TEST_DSN': JSON.stringify(process.env.E2E_TEST_DSN) }, | ||
| }, | ||
| watch: false, | ||
| scripts: { |
Member
There was a problem hiding this comment.
I think you'll get an error here but there are two script keys
Comment on lines
+93
to
+95
| asyncStart() {}, | ||
| asyncEnd() {}, | ||
| error() {}, |
Member
There was a problem hiding this comment.
Can those be removed? Check if this is optional
Patches createAssetServer so every browser module it serves carries a debug ID, with no config from the app. Source maps follow the other meta framework SDKs: generated but hidden unless the app configures them. Fixes #24667 Refs JS-3770 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3770-integrate-with-the-remix-3-asset-server-for-debug-ids
branch
from
October 1, 2026 13:33
78f8a55 to
dc1a7a0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remix 3 has no build step, so there is no bundler plugin to inject debug IDs. The asset server compiles each module on request, and this patches
createAssetServerto add a loader that injects the debug ID snippet into every compiled module. The ID is a hash of the compiled source and the module URL, so it is stable across requests and the source map upload can arrive at the same ID in another process.The minifier drops comments and the asset server rebuilds source maps after the loaders ran. So the
//# debugId=comment and thedebugIdfield in the map, which is whatsentry-clireads, are added to the served response instead.Source maps follow the other meta framework SDKs. Left out, they are generated but hidden: modules do not reference them and
.maprequests are not served.sourceMaps: falsekeeps them off, with a warning that stack traces stay minified.getDebugIdand the snippet mirror@sentry/bundler-plugins/corerather than importing it, because that entry loads the whole build plugin into the server.Fixes #24667