Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
chore/upgrade-vitest-4
branch
2 times, most recently
from
September 28, 2026 08:49
1598459 to
4be15ae
Compare
Member
Author
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 4be15ae. Configure here.
Lms24
force-pushed
the
chore/upgrade-vitest-4
branch
from
September 28, 2026 09:20
4be15ae to
f84706f
Compare
Vitest 3 transitively pulled in DOM lib types, which the bun and cloudflare integration tests relied on. Add DOM to the bun tsconfig lib, matching node-integration-tests whose runner the bun suites now compile, and reference the DOM lib in the browser-only cloudflare client file. Vite 8 types the plugin `config` hook with a `ConfigPluginContext` `this`, which broke nuxt's typechecked unit tests. Cast the hook before calling it, as the remix tests already do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Bump deno-integration-tests and the debug-id-sourcemaps e2e app to Vitest 4. Vitest 4 no longer accepts test options as the third argument, so pass them second. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Vitest 4 rejects projects that share a `sequence.groupOrder` but set different `maxWorkers`. The `bun` project pins `maxWorkers: 1`, so it now runs in a separate group after the node suites. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Lms24
force-pushed
the
chore/upgrade-vitest-4
branch
from
September 28, 2026 09:56
f84706f to
68c0334
Compare
Lms24
added this pull request to stack #24790
September 28, 2026 09:56
Lms24
changed the title
Lms24
marked this pull request as ready for review
September 28, 2026 12:31
Lms24
requested review from
JPeer264,
isaacs,
logaretm,
msonnb,
nicohrubec and
s1gr1d
and removed request for
a team
September 28, 2026 12:31
JPeer264
approved these changes
Sep 29, 2026
| const build = config.build || {}; | ||
| // SolidStart builds with vinxi's Vite, which predates `rolldownOptions` | ||
| // oxlint-disable-next-line typescript/no-deprecated | ||
| const rollupOptions = build.rollupOptions || {}; |
Member
There was a problem hiding this comment.
q: Do we need to have a follow up ticket for this to change it to rolldownOptions?
Member
Author
There was a problem hiding this comment.
It's a good point. The Vite bump here raises that rollupVersions is now an alias of rolldownOptions. Switching would break support for older Vite versions though. So we likely need to set the correct property based on vite version to be fully compatible in the long run. Let me ask our bundler plugin experts.
s1gr1d
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Vitest to v4, and Vite to v8. In a previous attempt that kept Vite on v7, we encountered several problems with yarn, hence I made the jump to vite 8 directly. Shouldn't affect anything else, since we only use vite for vitest.
Changes:
vitestand@vitest/coverage-v8from 3.2 to 4.1 across the monorepo.viteto 8 in packages that previously pinned Vite 6 or 7.poolOptions.threads.singleThreadwithmaxWorkers: 1in the bun and cloudflare integration tests.sequence.groupOrder, which Vitest 4 requires for projects with differentmaxWorkers.vitest-esm-onlyplugin withenforce: 'pre'so TS transpilation can't move its marker comments.functionimplementations for mocks called withnew, which Vitest 4 no longer allows as arrow functions.vi.restoreAllMocks()no longer resetsvi.fn()mocks.