Conversation
chargome
added this pull request to stack #24699
September 24, 2026 12:42
Member
Author
|
bugbot run |
Registers a Remix 3 app in the e2e matrix with two smoke tests, so later pull requests add instrumentation and its tests together instead of also introducing a new CI surface. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
chargome
force-pushed
the
charlygomez/js-3765-remix-3-e2e-app
branch
from
September 24, 2026 12:49
94b4e5f to
d640c4f
Compare
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d640c4f. Configure here.
chargome
marked this pull request as ready for review
September 24, 2026 13:12
nicohrubec
approved these changes
Sep 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Remix 3 app to the e2e matrix, stacked on #24697.
There is no instrumentation yet, so the two smoke tests assert only that the plumbing holds: the app boots under
--import @sentry/remix/v3/node, andSentry.init()from the@sentry/remix/v3subpath sends a server span. Span names are still URL based.The app exists at this point in the stack so later pull requests add instrumentation and its tests together, instead of also introducing a new CI surface. Each of those restores its own test file.
The browser entry calls no Sentry API, because
./v3/clientwithholdsinituntil the browser SDK lands.