Conversation
chargome
added this pull request to stack #24684
September 24, 2026 09:07
Member
Author
|
bugbot run |
Contributor
size-limit report 📦
|
Member
Author
|
bugbot run |
chargome
force-pushed
the
feat/prisma-8-tests
branch
from
September 24, 2026 09:30
01e2f54 to
5acb09a
Compare
Prisma 8 ("Prisma Next") ships no tracing surface, so `prismaIntegration`
is inert there and only the `pg` query spans remain. Pin that behaviour
against 8.0.0-rc.8 so a Prisma release that adds a tracing surface, or
breaks the `pg` path, shows up.
The emitted `contract.json` and an `init.sql` dumped from `prisma-cli db
init` are committed: the Prisma 8 CLI needs Node 22.18+ and breaks npm's
peer-dependency resolution. The contract has no `DateTime` column, since
Prisma 8 decodes timestamps into `Temporal`, global only on Node 26.
The runner's ESM-to-CJS converter now drops `with { type: 'json' }`
import attributes so the scenario can import the contract.
Refs #24237
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
chargome
force-pushed
the
feat/prisma-8-tests
branch
from
September 24, 2026 10:13
5acb09a to
b618c97
Compare
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b618c97. Configure here.
chargome
marked this pull request as ready for review
September 24, 2026 12:03
chargome
requested review from
JPeer264,
andreiborza and
isaacs
and removed request for
a team
September 24, 2026 12:03
JPeer264
approved these changes
Sep 25, 2026
| const db = prismaPostgres.default({ contractJson, url }); | ||
| // With `require(esm)` the module-injection notice arrives on a later tick, so a call in the same | ||
| // tick as the require would run before the SDK subscribes to the channels. | ||
| await new Promise(resolve => setImmediate(resolve)); |
Member
There was a problem hiding this comment.
m/q: Isn't that an issue users would face too?
| await db.orm.public.User.where(user => user.email.like('%sentry.io')).delete(); | ||
|
|
||
| setTimeout(async () => { | ||
| span.end(); |
Member
There was a problem hiding this comment.
l/q: Is this span.end() needed in this scenario? Since setTimeout is not blocking and would have ended the span by then already
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prisma 8 ("Prisma Next", rc.8) has no tracing surface, so
prismaIntegrationis inert there. This suite pins what we get today: only thepgquery spans frompostgresIntegration.contract.json/init.sqlare committed: the Prisma 8 CLI needs Node ≥ 22.18 and breaks npm's peer resolution.with { type: 'json' }import attributes.Refs #24237