Conversation
Only root-relative hrefs get the basePath prefix, mirroring Next.js' own addPathPrefix. Previously, absolute URLs passed to router.push/replace (e.g. from a redirect() to an absolute URL) produced span names like /my-apphttp://host/login. Fixes #24672 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
fix/nextjs-basepath-absolute-url
branch
from
September 24, 2026 10:04
8b0b2ae to
5f9e86e
Compare
Lms24
marked this pull request as ready for review
September 24, 2026 10:07
Lms24
requested review from
chargome and
nicohrubec
and removed request for
a team
September 24, 2026 10:07
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a potentially set
basePathwould be preprended to absolute URL router pushes, resulting in incorrect navigation spans. This is done by hardening the check whether to apply thebasePathor not.Fixes #24672