Skip to content

ci: shard Node integration tests and increase browser Playwright workers #24676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nicohrubec wants to merge 10 commits into
base: develop
Choose a base branch
from
+11 −2
Draft

ci: shard Node integration tests and increase browser Playwright workers #24676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c27d965
ci: collect Node integration test timings
nicohrubec Sep 24, 2026
7bf8ce3
ci: shard Node integration tests across two runners
nicohrubec Sep 24, 2026
ed5b3fb
ci: try three shards for Node integration tests
nicohrubec Sep 24, 2026
c5b9cb1
ci: parallelize browser bundle builds across three processes
nicohrubec Sep 24, 2026
1a5eff7
revert: parallel browser bundle builds
nicohrubec Sep 24, 2026
8690594
build: reuse debug bundle builds for minified output
nicohrubec Sep 24, 2026
2aa229d
ci: focus experiment on test parallelism
nicohrubec Sep 24, 2026
7080ca9
ci: retry browser bundle sharding with six Playwright workers
nicohrubec Sep 24, 2026
cda6116
ci: try six workers across Playwright suites
nicohrubec Sep 24, 2026
757384f
ci: keep six workers only for browser Playwright
nicohrubec Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ jobs:
job_node_integration_tests:
name:
Node (${{ matrix.node }})${{ (matrix.typescript && format(' (TS {0})', matrix.typescript)) || '' }} Integration
Tests
Tests (shard ${{ matrix.shard }}/3)
needs: [job_get_metadata, job_build]
if: needs.job_build.outputs.changed_node_integration == 'true' || github.event_name != 'pull_request'
runs-on: ubuntu-24.04
Expand All @@ -792,12 +792,20 @@ jobs:
fail-fast: false
matrix:
node: [20.19, 22, 24, 26]
shard: [1, 2, 3]
typescript:
- false
include:
# Only check typescript for latest version (to streamline CI)
- node: 24
typescript: '5.0'
shard: 1
- node: 24
typescript: '5.0'
shard: 2
- node: 24
typescript: '5.0'
shard: 3
steps:
- name: Check out current commit (${{ needs.job_get_metadata.outputs.commit_label }})
uses: actions/checkout@v7
Expand Down Expand Up @@ -832,7 +840,7 @@ jobs:

- name: Run integration tests
working-directory: dev-packages/node-integration-tests
run: yarn test
run: yarn test --shard=${{ matrix.shard }}/3

job_cloudflare_integration_tests:
name: Cloudflare Integration Tests
Expand Down
1 change: 1 addition & 0 deletions dev-packages/browser-integration-tests/playwright.browser.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import CorePlaywrightConfig from './playwright.config';

const config: PlaywrightTestConfig = {
...CorePlaywrightConfig,
workers: process.env.CI ? 6 : CorePlaywrightConfig.workers,
testDir: './suites',
};

Expand Down
Loading