Conversation
The Bun package had its own copy of the scenario runner and envelope assertions. The Bun-only suites now use the runner of `node-integration-tests`, so one runner serves all scenarios. The `captureMessage` test in `basic` is removed, because the shared `public-api` suites cover it with `@sentry/bun`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
added this pull request to stack #24670
September 23, 2026 16:19
Contributor
size-limit report 📦
|
JPeer264
marked this pull request as ready for review
September 23, 2026 16:31
JPeer264
requested review from
andreiborza,
isaacs and
mydea
and removed request for
a team
September 23, 2026 16:31
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
removed this pull request from stack #24670
September 23, 2026 17:26
JPeer264
added this pull request to stack #24671
September 23, 2026 17:31
isaacs
approved these changes
Sep 23, 2026
| test('sets sentry.is_localhost on every streamed span', async () => { | ||
| const runner = createRunner(__dirname, 'index.ts') | ||
| .withMockSentryServer() | ||
| .unordered() |
Member
There was a problem hiding this comment.
This is unnecessary and weakens the test slightly, since there's only one expectation.
Suggested change
| .unordered() |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Bun package had its own copy of the scenario runner and envelope assertions (
runner.ts,expect.ts). Now that the shared runner ofnode-integration-testscan start scenarios with Bun, the Bun-only suites use it too, so one runner serves all scenarios and the copy goes away.The
captureMessagetest inbasicis removed, because the sharedpublic-apisuites already cover it with@sentry/bun.Part of #23889.
🤖 Generated with Claude Code