fix(replay): attach replay ID from when the feedback widget opened - #24570
Merged
mydea merged 4 commits intoSep 22, 2026
Conversation
The widget flushes the replay when it opens, but the replay ID was read at submission. If the session refreshed while the form was open, feedback linked to a new, unsent buffered replay instead of the one that was flushed. Keep the replay ID captured on open for widget submissions. Refs REPLAY-1000 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JoshuaKGoldberg
changed the title
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ffa138a. Configure here.
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoshuaKGoldberg
marked this pull request as ready for review
September 21, 2026 15:59
JoshuaKGoldberg
requested review from
Lms24,
billyvg and
logaretm
and removed request for
a team
September 21, 2026 15:59
logaretm
reviewed
Sep 21, 2026
logaretm
left a comment
logaretm
left a comment
Member
There was a problem hiding this comment.
A couple of comments, otherwise LGTM
Also clear the replay ID captured on widget open once it's used, and cover feedback sent after replay is stopped. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JoshuaKGoldberg
commented
Sep 21, 2026
|
|
||
| if (isFeedbackEvent(event)) { | ||
| // The feedback widget links the replay from when it was opened. If the session | ||
| // refreshed since then, don't flush or add a breadcrumb to the unlinked new session |
Member
Author
There was a problem hiding this comment.
[Non-Actionable] Fun fact: this is one of the few times recently I've added a comment. Cursor didn't write one originally! But I figured the rest of this area/file is pretty comment-rich.
mydea
deleted the
joshgoldberg/replay-1000-flush-recording-buffer-when-user-feedback-is-opened-vs-sent
branch
September 22, 2026 06:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#17236 (just over a year ago) actually already flushes the replay when the feedback widget opens. But the replay ID was read at submission, so a session refresh while the form was open linked the feedback to a new, never-sent buffered replay. Widget submissions now use the replay ID captured when the widget opened.
Closes REPLAY-1000.