Skip to content

fix(elysia): Set SDK metadata on the options passed to init #24521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shubham-Padkonde wants to merge 4 commits into
base: develop
Choose a base branch
from
+14 −19
Open

fix(elysia): Set SDK metadata on the options passed to init #24521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
428c94f
fix(elysia): Set SDK metadata on the options passed to init
Shubham-Padkonde Sep 19, 2026
4a278b7
test(elysia): assert metadata received by the runtime SDK
Shubham-Padkonde Sep 24, 2026
68cf670
test(elysia): assert SDK name in both runtime apps
Shubham-Padkonde Sep 24, 2026
7fe29ad
Merge develop and assert Bun runtime metadata without removed mock
Shubham-Padkonde Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/elysia-bun/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ test('Captures an error thrown in a route handler', async ({ baseURL, request })
});

expect(errorEvent.transaction).toEqual('GET /test-exception/:id');
expect(errorEvent.sdk?.name).toBe('sentry.javascript.elysia');

expect(errorEvent.contexts?.trace).toEqual(
expect.objectContaining({
Expand Down
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/elysia-node/tests/errors.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ test('Captures an error thrown in a route handler', async ({ baseURL, request })
});

expect(errorEvent.transaction).toEqual('GET /test-exception/:id');
expect(errorEvent.sdk?.name).toBe('sentry.javascript.elysia');

expect(errorEvent.contexts?.trace).toEqual(
expect.objectContaining({
Expand Down
2 changes: 1 addition & 1 deletion packages/elysia/src/sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export function init(userOptions: ElysiaOptions = {}): NodeClient | undefined {
serverName: userOptions.serverName || global.process.env.SENTRY_NAME || os.hostname(),
};

applySdkMetadata(userOptions, 'elysia', ['elysia', options.runtime.name]);
applySdkMetadata(options, 'elysia', ['elysia', options.runtime.name]);

options.transport = options.transport || makeFetchTransport;

Expand Down
29 changes: 11 additions & 18 deletions packages/elysia/test/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,10 @@
import type { Integration } from '@sentry/core';
import { afterEach, describe, expect, it, vi } from 'vitest';

const mockApplySdkMetadata = vi.fn();
const mockInitNode = vi.fn();
const mockGetBunDefaultIntegrations = vi.fn(() => [] as Integration[]);
const mockMakeFetchTransport = vi.fn();

vi.mock('@sentry/core', async importActual => {
// eslint-disable-next-line @typescript-eslint/consistent-type-imports
const actual = await importActual<typeof import('@sentry/core')>();
return {
...actual,
applySdkMetadata: mockApplySdkMetadata,
};
});

vi.mock('@sentry/bun', () => ({
init: mockInitNode,
getDefaultIntegrations: mockGetBunDefaultIntegrations,
Expand All @@ -32,13 +22,13 @@ describe('init', () => {
vi.unstubAllGlobals();
});

it('sets SDK metadata to elysia', () => {
it('passes Elysia SDK metadata to initNode', () => {
init({ dsn: 'https://examplePublicKey@o0.ingest.sentry.io/0' });

expect(mockApplySdkMetadata).toHaveBeenCalledWith(
expect.objectContaining({ dsn: 'https://examplePublicKey@o0.ingest.sentry.io/0' }),
'elysia',
['elysia', 'node'],
expect(mockInitNode).toHaveBeenCalledWith(
expect.objectContaining({
_metadata: { sdk: expect.objectContaining({ name: 'sentry.javascript.elysia' }) },
}),
);
});

Expand Down Expand Up @@ -115,9 +105,12 @@ describe('init', () => {

init({ dsn: 'https://***@o0.ingest.sentry.io/0' });

const calledOptions = mockInitNode.mock.calls[0]![0];
expect(calledOptions.runtime).toEqual({ name: 'bun', version: '1.2.3' });
expect(mockApplySdkMetadata).toHaveBeenCalledWith(expect.anything(), 'elysia', ['elysia', 'bun']);
expect(mockInitNode).toHaveBeenCalledWith(
expect.objectContaining({
runtime: { name: 'bun', version: '1.2.3' },
_metadata: { sdk: expect.objectContaining({ name: 'sentry.javascript.elysia' }) },
}),
);
});
});

Expand Down
Loading