fix(core): avoid retrying failing MCP handlers - #24505
Merged
Merged
Conversation
Co-Authored-By: GPT-5 <codex@openai.com>
betegon
marked this pull request as ready for review
September 18, 2026 13:41
betegon
requested review from
isaacs and
mydea
and removed request for
a team
September 18, 2026 13:41
Contributor
size-limit report 📦
|
betegon
requested review from
JPeer264
and removed request for
isaacs and
mydea
September 18, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wrapMcpServerWithSentryretries synchronous handler failures after capturing them. This can repeat application side effects and replace the original failure with a successful retry response.Remove that fallback while preserving the existing return-value and async error behavior. The regression is reproduced with both TypeScript SDK majors and in a deployed Cloudflare Worker, including negotiated MCP
2026-07-28.Fixes #24504