Conversation
mydea
added this pull request to stack #24498
September 18, 2026 10:39
Contributor
size-limit report 📦
|
Relocate the runtime-agnostic Hono instrumentation out of `@sentry/hono` into `packages/server-utils/src/integrations/hono/`, with `@sentry/hono` re-exporting it. Server-utils must not depend on `hono`, so the relocated code no longer imports it (the `Hono` class is passed in by the SDK and a vendored `honoTypes` provides the shapes). The `sentry()` middleware now builds its request handler via the shared `createHonoRequestMiddleware`. No behavior change. Also renames the `hono-4` e2e test app to `hono-4-legacy` and moves the corresponding unit tests alongside the relocated code. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Align the middleware definitions and assertions in the hono-4-legacy e2e app with the hono-4 app: anonymous function expressions (name inferred from the const binding, stable when bundled), a unique per-throw error suffix, and matching error assertions. Add a named-function middleware case, and a degraded-response test that documents the manual sentry() middleware does not capture errors thrown solely inside an internal sub-app .request() (unlike the auto-instrumentation). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
feat/hono-move-to-server-utils
branch
from
September 21, 2026 08:13
57d3514 to
09ebc47
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 09ebc47. Configure here.
s1gr1d
approved these changes
Sep 21, 2026
s1gr1d
left a comment
s1gr1d
left a comment
Member
There was a problem hiding this comment.
LGTM, only one comment about the deleted tests.
Comment on lines
+186
to
+197
| test.describe('error inside internal fetch (degraded response)', () => { | ||
| // The manual `sentry()` middleware only instruments the main app's request lifecycle. An error | ||
| // thrown solely inside an internal sub-app `.request()` — whose failed response the outer handler | ||
| // swallows — is therefore NOT captured here, unlike the orchestrion auto-instrumentation in the | ||
| // `hono-4` app, which instruments every dispatched context. We assert only that the outer request | ||
| // stays healthy. | ||
| test('degrades to a 200 when the inner route fails', async ({ baseURL }) => { | ||
| const response = await fetch(`${baseURL}${STOREFRONT}/product/self-watering-plant/degraded`); | ||
| expect(response.status).toBe(200); | ||
| await expect(response.json()).resolves.toEqual({ product: null, degraded: true }); | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Why was this and wrapMiddlewareSpan deleted?
Member
Author
There was a problem hiding this comment.
we'd need to export this from server-utils to be able to test this in the hono package 😢 not 100% sure...
Member
There was a problem hiding this comment.
ohhh 😬 then we should at least test this E2E
Member
Author
There was a problem hiding this comment.
I added some node-integration tests etc. to cover the things that we used to cover before. I think coverage should be decent now!
The Cloudflare and Deno Hono adapters imported applyHonoPatches, earlyPatchHono and createHonoRequestMiddleware from the main @sentry/server-utils entry, whose barrel also loads node:diagnostics_channel and other Node-only modules — which can fail at import/bundle time on Cloudflare Workers and Deno. Export the runtime-agnostic helpers from `exports.ts` (shared by both entries), sourced directly from their modules rather than the ./integrations/hono barrel, so they are available from @sentry/server-utils/no-diagnostic-channels without pulling in diagnostics-channel. Point the Cloudflare and Deno adapters at that Node-free entry. Also move the applyHonoPatches wrapper out of the barrel into the Node-free applyPatches module. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
marked this pull request as ready for review
September 21, 2026 12:43
mydea
requested review from
chargome and
nicohrubec
and removed request for
a team
September 21, 2026 12:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of two stacked PRs splitting the Hono instrumentation rework (originally #24371).
Relocates the runtime-agnostic Hono instrumentation out of
@sentry/honointo@sentry/server-utils(src/integrations/hono/), with@sentry/honore-exporting it. Since@sentry/server-utilsmust not depend onhono, the relocated code no longer imports it: theHonoclass is passed in by the SDK and a vendoredhonoTypesmodule provides the shapes. Thesentry()middleware now builds its request handler via the sharedcreateHonoRequestMiddleware. Pure relocation — no behavior change.Also renames the
hono-4e2e test app tohono-4-legacyand moves the corresponding unit tests alongside the relocated code.The orchestrion-based auto-instrumentation that builds on this lives in the stacked PR #24497.
🤖 Generated with Claude Code